Announcement

Collapse
No announcement yet.

Radeon Page-Flipping Patches Come About

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

  • #21
    new patch up.

    Comment


    • #22
      Damn, I started compiling few minutes ago -.-
      ## VGA ##
      AMD: X1950XTX, HD3870, HD5870
      Intel: GMA45, HD3000 (Core i5 2500K)

      Comment


      • #23
        The good news is that it now passes the width test (both 1680), the bad news is that I'm now back to having a corrupted image . So they must have a different stride and pitch. And just like before it works again after using xrandr to switch to a different resolution and then back.

        Comment


        • #24
          Okay I think I found the inconsistency with regard to stride after xrandr resize. I think the initial stride of 1792 is correct, and the 1728 after xrandr not.

          In drmmode_xf86crtc_resize:

          Code:
          pitch = RADEON_ALIGN(width, drmmode_get_pitch_align(scrn, cpp, tiling_flags) / cpp);
          aligns to 64 bytes (256/cpp) Change it to:

          Code:
          pitch = RADEON_ALIGN(width, drmmode_get_pitch_align(scrn, cpp, tiling_flags));
          and xrandr now also gives a stride of 1792. Both same stride, bot same corruption with glxgears -fullscreen . Now there must be something changed in exa pixmap code to fix this I think.

          Btw There's also some pitch calculation code in RADEONSetPitch, maybe can be unified as well.

          Comment


          • #25
            Btw, are you testing with drm-next on top of 2.6.36? There's some regression there that leads to corrupted textures in at least Nexuiz, unrelated to color tiling or page flipping. git bisecting it here atm, sevenish iterations to go but kinda slow.

            Comment


            • #26
              No this is definitely pageflip problem, as

              Code:
              vblank_mode=0 glxgears -fullscreen
              gives no corruption

              Comment


              • #27
                If it's vblank-related, fine, might be completely separate. I run vblank off anyhow.

                Comment


                • #28
                  (is this the modern way to say I run with scissors?)

                  Comment


                  • #29
                    Ok, I think I fixed all the allocations. new commit to xf86-video-ati master and udpated ddx patches:

                    Comment


                    • #30
                      Originally posted by agd5f View Post
                      Ok, I think I fixed all the allocations. new commit to xf86-video-ati master and udpated ddx patches:
                      http://people.freedesktop.org/~agd5f/pflip/
                      I still see corruption in openarena with RV670.
                      ## VGA ##
                      AMD: X1950XTX, HD3870, HD5870
                      Intel: GMA45, HD3000 (Core i5 2500K)

                      Comment

                      Working...
                      X