Linux 5.1 Hit By A Data Loss Bug Due To Overly Aggressive FSTRIM

[Chugworth]

Well my main laptop has a Samsung SSD and the 5.1 kernel on an encrypted root partition. But I'm using Btrfs, so I have no need for LVM. Also, I don't use discard on encrypted drives. On a drive that's filled with what appears as random data, discard would go through and zero out sections of it based on usage patterns.

[Melcar]

So just using Samsung SSDs is not enough to get this problem? Using 5.1.4 right now.

[Britoid]

Oh, crap, this is exactly me. Fedora 29 with a Samsung SSD and an excrypted drive. I manually turned on the 'pass discards' setting in the LVM config.

Hope Fedora doesn't ship 5.1 before this gets fixed!

Fedora had 5.1 in testing, so as long as you never had the testing repo enabled you should be good.

[Veerappan]

Pretty sure my work laptop hits all of these criteria, except for maybe the Samsung SSD bit. It's a dm-crypt encrypted partition with discards passed through and is running 5.1.3, just not sure about the SSD manufacturer.

Definitely going to check on Monday.

[gbcox]

Fedora has already posted a fix: https://koji.fedoraproject.org/koji/...uildID=1270326

[willmore]

Oh, crap, this is exactly me. Fedora 29 with a Samsung SSD and an excrypted drive. I manually turned on the 'pass discards' setting in the LVM config.

Hope Fedora doesn't ship 5.1 before this gets fixed!

[Brisse]

Big thanks for this warning.. I was just considering upgrading to 5.1...

Yes, big thanks. My main system fulfills all of those conditions and I've been running Linux 5.1.3 for a few days. Immediately reverted to 4.19 when I saw the warning.

[milkylainen]

Maybe this is what I have been seeing under VirtualBox since just recently? Are Windows FSTRIM's passed on to the underlying device in VirtualBox?

[gQuigs]

Big thanks for this warning.. I was just considering upgrading to 5.1...

[deadite66]

Could this also effect veracrypt as it uses dm-crypt? , i've had 3 desktop (can still ssh with no errors seen) lockups during high disk IO since 5.1, been fine back on 5.0.