Originally posted by bridgman
View Post
gallium: remove TGSI opcode DPH
use DP4 or DP3 + ADD.
amd: normalize register definition formatting
This resolves trivial conflicts with gfx9d.h caused by different formatting. Some fields are also renamed.
gallium: add PIPE_CAP_TGSI_ANY_REG_AS_ADDRESS
(just setting the cap to 0 on old drivers)
util: move os_time.[ch] to src/util
(just moving the location of a header file into a shared location for other drivers)
etc.
These aren't r600 work, it's RadeonSI work that required adjusting old code in order to keep Mesa compiling. Pretty much the definition of legacy status to me.
Perhaps you can point me to 5 actual commits of real features/fixes being done to just the r600 driver in the last 6 months? That should be easy if, as you say, AMD is doing tons of work on them.
When you're done looking at their commits, open up some of Dave's commits and see where the RB's came from.
I went and looked through https://cgit.freedesktop.org/mesa/me...m/drivers/r600 since you kindly provided the url.
In "real" commits over the last 50 (1 page), Nicolai had a grand total of 1 acked by. No rbs at all.
2nd page (50-100): Roland S from VMWare actually has real commits present, changing the use of IEEE instructions in order to fix an application. Reviewed by Dave, though, not AMD. Ah, there we go - the bottom half of that page has maybe 10 or so patches that Nicolai reviewed. That's good.
3rd page (100-150) - oh, hey! Here we go, there are 3-4 patches here by Marek that are actual bug fixes. Mostly seems like ports from SI code or regression fallout from the threaded gallium work, but I'll take it. And a handful of reviews.
And that's 6 months worth.
We didn't "leave" so not sure why you're saying you wish it had been "left" in better shape.
Leave a comment: