RADV Lands Fragment Shader Interlock Support - Useful For Emulators, DXVK & VKD3D

[phoronix]

Phoronix: RADV Lands Fragment Shader Interlock Support - Useful For Emulators, DXVK & VKD3D

Mesa's RADV Radeon Vulkan driver has merged support for VK_EXT_fragment_shader_interlock, which is a highly sought after extension by game emulators and also important for DirectX over Vulkan layering efforts and more...

https://www.phoronix.com/news/RADV-Adds-Frag-Shader-Interlock

[ms178]

Am I mistaken or have we just witnessed the most complex contribution to RADV from outside the usual Valve, Google, AMD crowd?

Congrats to Vitaliy for getting his work over the finish line.

[WiR3D]

Am I mistaken or have we just witnessed the most complex contribution to RADV from outside the usual Valve, Google, AMD crowd?

Congrats to Vitaliy for getting his work over the finish line.

Nope, not mistaken, and a first contribution from my impressions. Even Timur said its one of the most complex he's ever seen.

There were definitely some fumbles getting it over the line though, and some false alarms with tests, but it's merged. Will probably have some follow ups though, but from it's original state it's changed a ton, kinda have to admit I kinda like that Vitaly writes a book for each comment adding all the context for each part of his thinking. Makes it quite accessible to noobs like myself

[pinguinpc]

In my case with intel anv appear sometime ago but hardware is too weak (just cause 3 stay around 25fps)

[Inopia]

"Fine... I'll do it myself" moment

[MastaG]

Correct me if I'm wrong, but I'm reading DXVK and VKD3D benefit from this.
Why didn't Valve contribute this one then?
It helps the Steam Deck and gaming on Linux in general right?

[darkbasic]

kinda have to admit I kinda like that Vitaly writes a book for each comment adding all the context for each part of his thinking. Makes it quite accessible to noobs like myself

I think the same, it's probably the first time I've read "too many comments" in a review.

[darkbasic]

Correct me if I'm wrong, but I'm reading DXVK and VKD3D benefit from this.
Why didn't Valve contribute this one then?
It helps the Steam Deck and gaming on Linux in general right?

It's FOSS, everybody is free to contribute whatever he wants: it doesn't have to necessarily be Valve

[ms178]

Correct me if I'm wrong, but I'm reading DXVK and VKD3D benefit from this.
Why didn't Valve contribute this one then?
It helps the Steam Deck and gaming on Linux in general right?

Maybe it wasn't a priority for them to implement that specific feature at this time themselves. But as they actively reviewed this massively complex patchset, I'd say they did their fair share of work on this, too, to bring this over the finish line.

[WiR3D]

Maybe it wasn't a priority for them to implement that specific feature at this time themselves. But as they actively reviewed this massively complex patchset, I'd say they did their fair share of work on this, too, to bring this over the finish line.

Definitely agree with this, that review effort was not simple. And they had multiple resources including Samuel reviewing it. Let alone the amount of input they gave to get the MR in its final form.