I wonder if any applications depend on the new (now reverted) behaviour. And what they will do if that is the case.
Announcement
Collapse
No announcement yet.
Linux Changes Pipe Behavior After Breaking Problematic Android Apps On Recent Kernels
Collapse
X
-
Originally posted by loganj View Postthis is definitely strange. i never expected that linux will revert a good patch for the sake of some applications.
nicely done.
and to think that they have issues with nvidia not being opensource friendly.
You put it out, then you go back and see what happened. This was the right course, they'll address this in the future so it seldom happens, but of course, it will happen. I agree with the post earlier about API abuse, though.
- Likes 6
Comment
-
I do believe in "We do not break userspace".
But not at any cost. This was a reasonable change.
If it took 2 bloody years to notice enough to make it revert then it's not an issue.
They can recompile their code or patch their release.
Better yet. Give me back non-stupid behavior and let Android #¤%#¤% tune a knob with sysctl for stupid behavior.
- Likes 6
Comment
-
As far as I understand, only a small part of the original improvement was reverted (a probably minor optimization that avoids checking for readers).
Without knowing the API or its use, it seems the strange thing is that the API allows blocked readers even when the pipe isn't empty anymore. However as long as the API allows that situation, then what else should wake those readers? So I guess the correct behavior is to wake blocked readers on any write. And I guess an application which doesn't want that behavior would not have any blocked readers waiting for a non-empty pipe, in the first place.
Again, I am saying this without knowing the API or its use, just from the description here and in the links. However if I understood it correctly, this partial revert shouldn't be a problem.Last edited by indepe; 31 July 2021, 03:15 PM.
- Likes 8
Comment
-
Originally posted by Vistaus View PostWhy would this be an issue? I thought all Android phones used ancient kernel versions?
This has broken "numerous Android applications" since Linux 5.5, but given the long period of times between kernel versions shipped by Android, it only has become a problem recently with Android transitioning to Linux 5.10 LTS
- Likes 5
Comment
Comment