Linus Ends Up Accepting The DRM Changes For Linux 4.11
While Linus Torvalds yesterday was criticizing the DRM code quality using colorful language and threatening not to accept the DRM changes for Linux 4.11, he ended up merging the code to mainline.
After complaining about the code and making some changes to it for reducing the compiler warnings, he ended up letting all of this new Direct Rendering Manager code be merged rather than dropping TinyDRM or not merging any DRM code at all.
Linus wrote in the merge, "This was the "fixed" pull, that still had build warnings due to people not even having build tested the result. I'm not a happy camper I've fixed the things I noticed up in this merge."
So at least the DRM feature changes made it for Linux 4.11. Intel DRM maintainer Daniel Vetter also decided to comment on Torvalds choice of wording for criticizing the TinyDRM code quality. While he admits that the DRM workflow and merge process could be improved upon and they'll discuss that for the future, he's concerned Torvalds' language and criticism toward new contributors could turn people off from contributing to the Linux kernel.
After complaining about the code and making some changes to it for reducing the compiler warnings, he ended up letting all of this new Direct Rendering Manager code be merged rather than dropping TinyDRM or not merging any DRM code at all.
Linus wrote in the merge, "This was the "fixed" pull, that still had build warnings due to people not even having build tested the result. I'm not a happy camper I've fixed the things I noticed up in this merge."
So at least the DRM feature changes made it for Linux 4.11. Intel DRM maintainer Daniel Vetter also decided to comment on Torvalds choice of wording for criticizing the TinyDRM code quality. While he admits that the DRM workflow and merge process could be improved upon and they'll discuss that for the future, he's concerned Torvalds' language and criticism toward new contributors could turn people off from contributing to the Linux kernel.
30 Comments