RADV Driver Enables Command Buffer Chaining, Boosts Dota 2 Performance

[phoronix]

Phoronix: RADV Driver Enables Command Buffer Chaining, Boosts Dota 2 Performance

The RADV Radeon Vulkan driver has now enabled command buffer chaining "batchchain" by default in the name of performance...

http://www.phoronix.com/scan.php?page=news_item&px=RADV-Batch-Chaining-Default

[andrebrait]

ws->batchchain = !!(perftest_flags & RADV_PERFTEST_BATCHCHAIN)

I'm sure there's a reason for the double negation and stuff but it made me giggle.

[andrei_me]

double negation

Is usually used as a type cast to boolean

[darkbasic]

Is usually used as a type cast to boolean

Exactly, it's a way to cast to boolean.

[illwieckz]

Everytime I see a bang bang in code this music plays in my brain:

[pal666]

double negation

it is !=0 but one char shorter

[pal666]

Is usually used as a type cast to boolean

Exactly, it's a way to cast to boolean.

no, it is not a cast to boolean. you don't need to do anything to cast to boolean, just return value or assign it to boolean. either for c++ bool, or for c _Bool.
it is a conversion to integer with value of either 0 or 1 which is an eye-bleeding garbage here. it is an artefact from prehistoric world without booleans

[airlied]

Pretty sure Bas wrote those patches Michael

[Zan Lynx]

no, it is not a cast to boolean. you don't need to do anything to cast to boolean, just return value or assign it to boolean. either for c++ bool, or for c _Bool.
it is a conversion to integer with value of either 0 or 1 which is an eye-bleeding garbage here. it is an artefact from prehistoric world without booleans

It's still a good habit because you never know when someone is going to be stupid and write `value == TRUE` which will only match if an integer is actually set to `1`. And you don't always know if a field is a `bool` or an `int`.

[timofonic]

Everytime I see a bang bang in code this music plays in my brain:

Someone must make a geek parody version of it about that code stuff in Weird Al Yankovik style