Announcement

Collapse
No announcement yet.

DRM Updates Submitted For Linux 4.11, Torvalds Explodes Over Code Quality

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

  • DRM Updates Submitted For Linux 4.11, Torvalds Explodes Over Code Quality

    Phoronix: DRM Updates Submitted For Linux 4.11, Torvalds Explodes Over Code Quality

    David Airlie submitted the main DRM driver updates for the Linux 4.11 kernel, but Linus Torvalds isn't happy about the code quality of a new addition and is considering not accepting the DRM changes for this next kernel release...

    http://www.phoronix.com/scan.php?pag...tes-Linux-4.11

  • #2
    Good reminder to those few people think that he'll just accept the AMDGPU DC code as a placeholder to get the cards supported that he almost certainly wont. Not saying his atitude's a great thing but it's what you need to work around cause he aint mellowing out as he gets older

    Comment


    • #3
      This is absolutely the correct attitude to have when you're the maintainer of something as important as Linux. Code quality matters, and bad code absolutely should be rejected.

      Comment


      • #4
        Wow, that code must be really disastrous.

        Comment


        • #5
          Having suffered from bad drivers (obviously as the result of merged code), I applaud the attitude. Bad code in the kernel should be illegal.

          Comment


          • #6
            Insert obligatory F--- You Nvidia gif.

            Comment


            • #7
              Originally posted by SpyroRyder View Post
              Good reminder to those few people think that he'll just accept the AMDGPU DC code as a placeholder to get the cards supported that he almost certainly wont. Not saying his atitude's a great thing but it's what you need to work around cause he aint mellowing out as he gets older
              I disagree. His main problem with this code was that it wouldn't even compile, which then caused him to dig further into it.

              He's generally ok with code that's ugly as long as it all works properly and is well tested. Check out the kdbus topic, for example. Linus wasn't real thrilled by that code, but ultimately it seemed like he would have merged it all if there was general agreement to have it go in. It was only all the vigorous objections that got him to finally reject it.

              Comment


              • #8
                Linus has a really bad approach yelling like a spoiled child -- and this is not the first or second time he did it. Of course good code is desirable, but it's made by group thinking and collaboration, not threatenings. A lot of people contributes to Linux OS because they believe in it, because they love it or simply because they want to help. Although these things maybe not enough, it's not behaving like Linus that we'll get things better.

                Comment


                • #9
                  Yeah, it's really bad. Thank god somebody has the heart to say it before it goes in. Needs more work, do the work! Don't waste the maintainer's time.

                  I look forward to a time when it is simpler to write a well-behaved DRM driver, but that will never come true if nobody's paying attention to the quality.
                  Last edited by microcode; 02-23-2017, 11:00 PM.

                  Comment


                  • #10
                    Originally posted by MaxToTheMax View Post
                    This is absolutely the correct attitude to have when you're the maintainer of something as important as Linux. Code quality matters, and bad code absolutely should be rejected.
                    Exactly. Millions of users worldwide, big and small, ultimately rely on and trust Linus to deliver a kernel which is a crucial part of their infrastructure. So the bad guy here is not Linus for calling out shit when he sees it, it's the DRM maintainers who clearly acted unprofessionally for pushing code that is absolutely not ready at the last minute (DISCLAIMER: I didn't actually look at the code, I write this based on the assumption that the driver really is as crappy as Linus says).

                    Comment

                    Working...
                    X