On-Disk Shader Cache Revised For Mesa, Close To Landing

[phoronix]

Phoronix: On-Disk Shader Cache Revised For Mesa, Close To Landing

Timothy Arceri of Collabora has updated the hardware agnostic portion of the on-disk shader cache patches...

http://www.phoronix.com/scan.php?page=news_item&px=Mesa-Shader-Cache-January-Patch

[shmerl]

Nice to see usage of XDG base directory spec in the patches. I hope radeonsi will get this cache as well.

[davidbepo]

the cache gets invalidated if version changes
but is it only major version or on every commit?

[tarceri]

the cache gets invalidated if version changes
but is it only major version or on every commit?

At this stage it is every commit, but we can tweak that if needed.

[davidbepo]

At this stage it is every commit, but we can tweak that if needed.

thanks for the quick response
i am on mesa git so i wont enable it till its finished

[Azpegath]

Aweeeesoooome! I feel that this might actually improve the Phoronix benchmark results for a couple of games since I guess shaders will sometimes be compiled during the first run of those. Since the game re-starts every time between benchmark runs, the shader compile would have a negative impact for every run as well. Perhaps enough to affect the mean FPS.

[Azpegath]

thanks for the quick response
i am on mesa git so i wont enable it till its finished

Why not? I guess in that case, you actually want it to be invalidated for every commit, since you want every commit to invalidate your cache if any shader optimizations have been committed.

[davidbepo]

Why not? I guess in that case, you actually want it to be invalidated for every commit, since you want every commit to invalidate your cache if any shader optimizations have been committed.

constant writes to ssd is not a good idea
the package is updated daily

[Azpegath]

constant writes to ssd is not a good idea
the package is updated daily

You are of course free to do whatever you want, but I wouldn't call "a couple of writes per day" for "constant writes" to SSD. An SSD implements "write leveling" and spreads "hot data" over the disk. Have you disabled all your internal logging as well, so those don't destroy your drive? Talk about constant writing...
I'm not saying you are wrong, just that you might be bikeshedding a bit, and perhaps strain at a gnat and swallow a camel.

[davidbepo]

You are of course free to do whatever you want, but I wouldn't call "a couple of writes per day" for "constant writes" to SSD. An SSD implements "write leveling" and spreads "hot data" over the disk. Have you disabled all your internal logging as well, so those don't destroy your drive? Talk about constant writing...
I'm not saying you are wrong, just that you might be bikeshedding a bit, and perhaps strain at a gnat and swallow a camel.

i know that and yes i've set journald to not save data, but also if the shaders have to be rebuilt daily the wins are much less
(some of the shader is saved even if rebuilt AFAIK)