Announcement

Collapse
No announcement yet.

R600 Gallium3D Picks Up Another OpenGL 4.5 Extension

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

  • #21
    Originally posted by smitty3268 View Post
    I guess it depends on your definition of support. Obviously the r600 family is in legacy support mode - from what i can see, AMD devs don't even work on bug fixes for r600 anymore, to the point of not even reviewing 3rd party patches fixing bugs.
    With respect, did you even look at the commit history ? It seems to tell a different story:

    https://cgit.freedesktop.org/mesa/me...m/drivers/r600

    Marek has at least 50 commits in 2017, and Nicolai has at least 20.

    When you're done looking at their commits, open up some of Dave's commits and see where the RB's came from.

    Originally posted by smitty3268 View Post
    I'd be a lot more generous with AMD on this topic if r600 had been left in better shape. Missing GL4 support and lots of bugs when trying to run against newer games meant that the choice between r600 and fgrlx wasn't really clear. Luckily Dave and some other 3rd party contributors have been stepping up to fix that, and hopefully in the future SI+ cards will be closer to feature complete by the time they're moved to legacy.
    We didn't "leave" so not sure why you're saying you wish it had been "left" in better shape.
    Last edited by bridgman; 02 December 2017, 06:13 PM.
    Test signature

    Comment


    • #22
      Originally posted by bridgman View Post

      With respect, did you even look at the commit history ? It seems to tell a different story:

      https://cgit.freedesktop.org/mesa/me...m/drivers/r600

      Marek has at least 50 commits in 2017, and Nicolai has at least 20.
      I'm sorry, but I just did look that over and all the AMD commits seem to be general refactorings of shared code, not anything to do with r600 directly.

      gallium: remove TGSI opcode DPH
      use DP4 or DP3 + ADD.

      amd: normalize register definition formatting
      This resolves trivial conflicts with gfx9d.h caused by different formatting. Some fields are also renamed.

      gallium: add PIPE_CAP_TGSI_ANY_REG_AS_ADDRESS
      (just setting the cap to 0 on old drivers)

      util: move os_time.[ch] to src/util
      (just moving the location of a header file into a shared location for other drivers)


      etc.

      These aren't r600 work, it's RadeonSI work that required adjusting old code in order to keep Mesa compiling. Pretty much the definition of legacy status to me.

      Perhaps you can point me to 5 actual commits of real features/fixes being done to just the r600 driver in the last 6 months? That should be easy if, as you say, AMD is doing tons of work on them.

      When you're done looking at their commits, open up some of Dave's commits and see where the RB's came from.
      I will say that Nicolai has recently been better at answering questions posed by Dave. Perhaps he was on vacation for a while, because he's the only one who tends to do that. He's not involved in most of the r600 work though.

      I went and looked through https://cgit.freedesktop.org/mesa/me...m/drivers/r600 since you kindly provided the url.

      In "real" commits over the last 50 (1 page), Nicolai had a grand total of 1 acked by. No rbs at all.

      2nd page (50-100): Roland S from VMWare actually has real commits present, changing the use of IEEE instructions in order to fix an application. Reviewed by Dave, though, not AMD. Ah, there we go - the bottom half of that page has maybe 10 or so patches that Nicolai reviewed. That's good.

      3rd page (100-150) - oh, hey! Here we go, there are 3-4 patches here by Marek that are actual bug fixes. Mostly seems like ports from SI code or regression fallout from the threaded gallium work, but I'll take it. And a handful of reviews.

      And that's 6 months worth.

      We didn't "leave" so not sure why you're saying you wish it had been "left" in better shape.
      I guess we'll just have to disagree on that.
      Last edited by smitty3268; 09 December 2017, 08:11 PM.

      Comment

      Working...
      X