Announcement

Collapse
No announcement yet.

More Than 100 More AMDGPU DC Patches Line Up Ahead Of Linux 4.15

Collapse
X
  • Filter
  • Time
  • Show
Clear All
new posts

  • More Than 100 More AMDGPU DC Patches Line Up Ahead Of Linux 4.15

    Phoronix: More Than 100 More AMDGPU DC Patches Line Up Ahead Of Linux 4.15

    AMDGPU DC is expected for Linux 4.15 assuming Linus Torvalds has no objections to merging the code. We hope it won't, but the code-base for this new AMD display code is outright massive at more than 120,000 lines of code over hundreds of patches. Today another 103 new patches were published...

    http://www.phoronix.com/scan.php?pag...=AMDGPU-DC-103

  • #2
    Should we be worried about that much churn just before it gets merged?

    Comment


    • #3
      Originally posted by boxie View Post
      Should we be worried about that much churn just before it gets merged?
      Looks pretty typical. It's all the changes they've made over the last month, I doubt anyone will have problems with it. Almost 2/3rds of the actual changed lines all look like they're coming from that DML which is apparently auto-generated hardware gospel.
      Last edited by smitty3268; 10-11-2017, 02:04 AM.

      Comment


      • #4
        assuming Linus Torvalds has no objections to merging the code. We hope it won't
        Umm... Was that a slip of the tongue or did they replace Linus with a bot when I wasn't looking?

        Comment


        • #5
          Originally posted by boxie View Post
          Should we be worried about that much churn just before it gets merged?
          Additional changes just show that the devs take it serious and that they do the best they can to get the code into a really good shape! We should be worried if there is no activity prior to the merge :-)

          Comment


          • #6
            People shouldn't blindly hope that DC gets merged. People should hope DC meets requirements. There's a big difference. You don't want to ruin the kernel with low-quality code just to get a video card working. Good thing Linus at least knows this.

            Comment


            • #7
              Originally posted by eydee View Post
              People shouldn't blindly hope that DC gets merged. People should hope DC meets requirements. There's a big difference. You don't want to ruin the kernel with low-quality code just to get a video card working. Good thing Linus at least knows this.
              He did insist on merging Nouveau because all the distros were shipping the code anyway

              Comment


              • #8
                Well, Nouveau is a reverse engineered driver - they are working off what they know, and can figure out, with almost zero help from NVIDIA.

                AMDGPU is an official driver written by AMD who makes the hardware - they have all of the info and details to write a good driver.

                Besides, code quality also matters - yes, you can reinvent the wheel, duplicate existing code/functionality, make code unnecessarily complicated - it's your choice, but there's a reason it's considered a bad practice by any experienced developer. This was recognized as a problem more than 30 years ago, and trust me, even today software developers make these kinds of fundamental mistakes and managers don't give a shit.

                Comment


                • #9
                  Originally posted by boxie View Post
                  Should we be worried about that much churn just before it gets merged?
                  Better before than after.
                  I think that there will also be progress after the merge, of course. But it is a large one with many corners, so I think quite some activity is normal.
                  Stop TCPA, stupid software patents and corrupt politicians!

                  Comment


                  • #10
                    Michael, could you please point out in your articles that HDMI audio support is only rudimentary. Right now only legacy audio formats are supported. There still is no support for HBR audio (Dolby TrueHD, DTS HD-MA, Dolby Atmos, DTS:X), see this bug report.

                    Comment

                    Working...
                    X