AMDGPU Fixes For Linux 5.0 Include FreeSync/VRR Properties For eDP Displays

[danger89]

What about the multi monitor support with FreeSync & AMDGPU?

[Haxk20]

The mainline kernel do have partially implemented and buggy amdgpu code (see the diff column at kernel.org), so use the AMD wip kernel. that has latest bug fixes and features.

Yes i know. Its just that AMD wip branch is on rc1. Also this isnt a bug. This is a feature only in 5.1

[Haxk20]

There are these ways:
- use your monitor built-in refresh rate counter
- to see the freesync range: sudo cat /sys/kernel/debug/dri/0/DP-1/vrr_range
- You can enable debug messages with the kernel command line, drm.debug=0x04. Then you have the following dmesg message if freesync is active: drm:update_freesync_state_on_stream.isra.32 [amdgpu]] VRR packet update: crtc=44 enabled=1 state=3

The game must use OpenGL and vsync. Only the displayport protocol is supported at the moment. Enable variable refresh rate in your xorg.conf file, see man amdgpu.

Also that /sys/kernel/debug/dri/0/DP-1/vrr_range is only existent with latest AMD patches from 5.1 WIP branch.

[Haxk20]

After 2 days i finally managed to get Freesync working on eDP display in Acer Nitro 5. Even tho i had to edit existing freesync EDID since idk of any way to add extension block to EDID it even with this works.
If anybody knows of way to add extension blocks to EDID without windows CRU please let me know

[Haxk20]

Do you know of any way to test if freesync is enabled ?

[agd5f]

Still missing the auto rotate screen function for mobile Raven Ridge

Generally this is handled by the desktop environment, not the driver. E.g., the desktop environment listens to the accelerometer and when it sees rotation, it calls into the display server to rotate the display.

[davidbepo]

The code does account for HDMI, DisplayPort and eDP connectors:

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index f4fa40c..0b392bf 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -4082,7 +4082,8 @@ void amdgpu_dm_connector_init_helper(struct amdgpu_display_manager *dm,
}

if (connector_type == DRM_MODE_CONNECTOR_HDMIA ||
- connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
+ connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
+ connector_type == DRM_MODE_CONNECTOR_eDP) {
drm_connector_attach_vrr_capable_property(
&aconnector->base);
}
--

https://cgit.freedesktop.org/~agd5f/...620f71eb2ab983


That Adaptive-Sync is part of the spec doesn't mean that every monitor needs to support a nontrivial range.

soo... freesync might work with hdmi after all

[finalzone]

Still missing the auto rotate screen function for mobile Raven Ridge

[chithanh]

"by accident" = unintended by manufacturer, lucky customers

I mean that with some panels, the EDID trick will not work because they genuinely do not support Adaptive-Sync.
While with others, it seems that the manufacturer had Adaptive-Sync capable panels which they did not intend to sell with Adaptive-Sync functionality, however overriding the EDID makes Adaptive-Sync work.

[starshipeleven]

That Adaptive-Sync is part of the spec doesn't mean that every monitor needs to support a nontrivial range.

So "by accident" you mean that they actually happen to support nontrivial ranges of adaptive sync by unrelated reasons? I'm curious of what you meant.