1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking.org

Samsung DRM Driver Could Make It Into The Kernel

Linux Kernel

Published on 30 August 2011 02:31 PM EDT
Written by Michael Larabel in Linux Kernel
1 Comment

Last week I wrote about Samsung releasing code to a new DRM driver for one of their ARM SoCs, the Exynos 4210 that's used by the Samsung Galaxy S II and other mobile devices. It looks like this open-source kernel driver from Samsung stands a chance as being the first ARM driver to be accepted into the DRM area of the mainline Linux kernel.

Samsung's Inki Dae sent another message last week to the mailing lists to target David Airlie in an attempt to achieve a response out of him. Inki was successful. David looked at the code and provided feedback. He didn't make any comments about reject the code outright based upon any missing open-source user-space driver suppot or anything else, like he has done in the past. His message commenting on Samsung's new open-source Direct Rendering Manager code is below.
I was sort of hoping someone else would take a look at these ARM drivers before me, it might be worth getting some inter-company review between the vendors submitting drm components as I'm guessing its going to be a lot of the same thing.

But I've done a quick review and some things that stick out.

1. include/drm/samsung_drm.h should only contain public information for use on the userspace ioctl interface, it shouldn't contain any kernel private data structures, they should be in drivers/gpu/drm/samsung/samsung_drv.h or something very similiar.

2. I'm not sure why samsung_drm_fn_encoder exists, it looks like from the crtc mode set functions you call the encoder mode set functions, is it not possible to use the helper drm_crtc_helper_set_mode so that the crtc mode set is called then the encoder ones without having the explicit calls? If not please either document it or point at the explaination I missed.

3. Not terribly urgent but is samsung the best name for this? what happens if you bring out another chip, I also think there is a lot of samsung_drm_ in function names that seems not that useful. dropping _drm_ might help.

4 ioctls: drm_samsung_gem_map_off needs explicit padding before the 64-bit, drm_samsung_gem_mmap needs explicit padding before the 64-bit,, though I'm not sure you need these ioctls all now that the dumb interface is upstream, what is usr_addr in the gem create ioctl for? this seems wrong, it also looks too short for 64-bit addresses, but passing in userspace addr to kernel is generally not a great plan.

5. you probably don't need master_create/set ops.

Dave.

Since that message he's also exchanged several more emails on the mailing list with Inki.

It's a different story from what he's said to Qualcomm or Texas Instruments in the past when they have published similar open-source DRM driver code for their ARM SoCs. It's a similar situation to VIA's failed attempts in the past at only partially open-source graphics stacks on Linux.

Let's see what happens here and whether the Samsung DRM driver manages to make it into the mainline Linux kernel.

Latest Linux Hardware Reviews
  1. ASUS AM1I-A: A Mini-ITX Board For Socketed Kabini APUs
  2. Mini-Box M350: A Simple, Affordable Mini-ITX Case
  3. Overclocking The AMD AM1 Athlon & Sempron APUs
  4. AMD Athlon 5350 / 5150 & Sempron 3850 / 2650
Latest Linux Articles
  1. Ubuntu 12.04.4 vs. 13.10 vs. 14.04 LTS Desktop Benchmarks
  2. AMD OpenCL Performance With AM1 Kabini APUs
  3. A Quick Look At GCC 4.9 vs. LLVM Clang 3.5
  4. Are AMD Athlon/Sempron APUs Fast Enough For Steam On Linux?
Latest Linux News
  1. FreeBSD Advances For ARM, Bhyve, Clang
  2. Ubuntu 14.04 LTS "Trusty Tahr" Officially Released
  3. Ubuntu 12.04 LTS vs. 14.04 LTS Server Benchmarks
  4. QEMU 2.0 Released With ARM, x86 Enhancements
  5. Running The Unity 8 Preview Session On Ubuntu 14.04 LTS
  6. R600 Gallium3D Disables LLVM Back-End By Default
  7. Fedora 21 Gets GNOME 3.12, PHP 5.6, Mono 3.4
  8. Fedora Workstation Is Making Me Quite Excited
  9. Maynard: A Lightweight Wayland Desktop
  10. Chromium Browser Going Through Growing Pains In Ubuntu 14.04
  11. KDE 4.13 Is Being Released Today With New Features
  12. Trying Out Radeon R9 290 Graphics On Open-Source
Latest Forum Discussions
  1. Updated and Optimized Ubuntu Free Graphics Drivers
  2. Linux Kernel Developers Fed Up With Ridiculous Bugs In Systemd
  3. The GNOME Foundation Is Running Short On Money
  4. Radeon 8000M problematic on Linux?
  5. After Jack Keane, RuseSoft will briing Ankh 3 to Linux through Desura
  6. Suspected PHP Proxy Issue
  7. Change installation destination from home directory
  8. Bye bye BSD, Hello Linux: A Sys Admin's Story