1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking.org

Samsung DRM Driver Could Make It Into The Kernel

Linux Kernel

Published on 30 August 2011 02:31 PM EDT
Written by Michael Larabel in Linux Kernel
1 Comment

Last week I wrote about Samsung releasing code to a new DRM driver for one of their ARM SoCs, the Exynos 4210 that's used by the Samsung Galaxy S II and other mobile devices. It looks like this open-source kernel driver from Samsung stands a chance as being the first ARM driver to be accepted into the DRM area of the mainline Linux kernel.

Samsung's Inki Dae sent another message last week to the mailing lists to target David Airlie in an attempt to achieve a response out of him. Inki was successful. David looked at the code and provided feedback. He didn't make any comments about reject the code outright based upon any missing open-source user-space driver suppot or anything else, like he has done in the past. His message commenting on Samsung's new open-source Direct Rendering Manager code is below.
I was sort of hoping someone else would take a look at these ARM drivers before me, it might be worth getting some inter-company review between the vendors submitting drm components as I'm guessing its going to be a lot of the same thing.

But I've done a quick review and some things that stick out.

1. include/drm/samsung_drm.h should only contain public information for use on the userspace ioctl interface, it shouldn't contain any kernel private data structures, they should be in drivers/gpu/drm/samsung/samsung_drv.h or something very similiar.

2. I'm not sure why samsung_drm_fn_encoder exists, it looks like from the crtc mode set functions you call the encoder mode set functions, is it not possible to use the helper drm_crtc_helper_set_mode so that the crtc mode set is called then the encoder ones without having the explicit calls? If not please either document it or point at the explaination I missed.

3. Not terribly urgent but is samsung the best name for this? what happens if you bring out another chip, I also think there is a lot of samsung_drm_ in function names that seems not that useful. dropping _drm_ might help.

4 ioctls: drm_samsung_gem_map_off needs explicit padding before the 64-bit, drm_samsung_gem_mmap needs explicit padding before the 64-bit,, though I'm not sure you need these ioctls all now that the dumb interface is upstream, what is usr_addr in the gem create ioctl for? this seems wrong, it also looks too short for 64-bit addresses, but passing in userspace addr to kernel is generally not a great plan.

5. you probably don't need master_create/set ops.

Dave.

Since that message he's also exchanged several more emails on the mailing list with Inki.

It's a different story from what he's said to Qualcomm or Texas Instruments in the past when they have published similar open-source DRM driver code for their ARM SoCs. It's a similar situation to VIA's failed attempts in the past at only partially open-source graphics stacks on Linux.

Let's see what happens here and whether the Samsung DRM driver manages to make it into the mainline Linux kernel.

About The Author
Michael Larabel is the principal author of Phoronix.com and founded the web-site in 2004 with a focus on enriching the Linux hardware experience and being the largest web-site devoted to Linux hardware reviews, particularly for products relevant to Linux gamers and enthusiasts but also commonly reviewing servers/workstations and embedded Linux devices. Michael has written more than 10,000 articles covering the state of Linux hardware support, Linux performance, graphics hardware drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated testing software. He can be followed via and or contacted via .
Latest Linux Hardware Reviews
  1. Trying The Configurable 45 Watt TDP With AMD's A10-7800 / A6-7400K
  2. Sumo's Omni Gets Reloaded
  3. AMD A10-7800 & A6-7400K APUs Run Great On Linux
  4. Radeon Gallium3D Is Running Increasingly Well Against AMD's Catalyst Driver
Latest Linux Articles
  1. Open-Source Radeon Graphics Have Some Improvements On Linux 3.17
  2. CPUFreq Scaling Tests With AMD's Kaveri On Linux 3.16
  3. Enabling HyperZ Is Still An Easy Way For Faster RadeonSI Performance
  4. AMD Kaveri: Catalyst vs. RadeonSI Gallium3D On Linux
Latest Linux News
  1. Qt5 Will Now Support LGPLv3 Modules
  2. Proposed: A Tainted Performance State For The Linux Kernel
  3. Systemd 216 Piles On More Features, Aims For New User-Space VT
  4. Mesa 10.2.6 Has Plenty Of OpenGL Driver Bug Fixes
  5. LXQt 0.8 Is Being Released Soon
  6. Linux 3.17 Lands Memfd, A KDBUS Prerequisite
  7. Humble Jumbo Bundle 2 Shafts Linux Gamers
  8. New VM Software Claims To Be 4.5x Faster Than QEMU
  9. Btrfs Gets Talked Up, Googler Encourages You To Try Btrfs
  10. Mesa Now Supports Another OpenGL 4.5 Extension
Latest Forum Discussions
  1. Remote gui not accessible in Phoronix Test Suite 5.2
  2. The dangers of Linux kernel development
  3. Dead Island for Linux (?)
  4. Updated and Optimized Ubuntu Free Graphics Drivers
  5. AMD Offers Mantle For OpenGL-Next, Pushes Mantle To Workstations
  6. Next-Gen OpenGL To Be Announced Next Month
  7. OpenGL 4.5 Released With New Features
  8. Updated graphics drivers for Ubuntu 12.04 Precise LTS