1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking.org

Samsung DRM Driver Could Make It Into The Kernel

Linux Kernel

Published on 30 August 2011 02:31 PM EDT
Written by Michael Larabel in Linux Kernel
1 Comment

Last week I wrote about Samsung releasing code to a new DRM driver for one of their ARM SoCs, the Exynos 4210 that's used by the Samsung Galaxy S II and other mobile devices. It looks like this open-source kernel driver from Samsung stands a chance as being the first ARM driver to be accepted into the DRM area of the mainline Linux kernel.

Samsung's Inki Dae sent another message last week to the mailing lists to target David Airlie in an attempt to achieve a response out of him. Inki was successful. David looked at the code and provided feedback. He didn't make any comments about reject the code outright based upon any missing open-source user-space driver suppot or anything else, like he has done in the past. His message commenting on Samsung's new open-source Direct Rendering Manager code is below.
I was sort of hoping someone else would take a look at these ARM drivers before me, it might be worth getting some inter-company review between the vendors submitting drm components as I'm guessing its going to be a lot of the same thing.

But I've done a quick review and some things that stick out.

1. include/drm/samsung_drm.h should only contain public information for use on the userspace ioctl interface, it shouldn't contain any kernel private data structures, they should be in drivers/gpu/drm/samsung/samsung_drv.h or something very similiar.

2. I'm not sure why samsung_drm_fn_encoder exists, it looks like from the crtc mode set functions you call the encoder mode set functions, is it not possible to use the helper drm_crtc_helper_set_mode so that the crtc mode set is called then the encoder ones without having the explicit calls? If not please either document it or point at the explaination I missed.

3. Not terribly urgent but is samsung the best name for this? what happens if you bring out another chip, I also think there is a lot of samsung_drm_ in function names that seems not that useful. dropping _drm_ might help.

4 ioctls: drm_samsung_gem_map_off needs explicit padding before the 64-bit, drm_samsung_gem_mmap needs explicit padding before the 64-bit,, though I'm not sure you need these ioctls all now that the dumb interface is upstream, what is usr_addr in the gem create ioctl for? this seems wrong, it also looks too short for 64-bit addresses, but passing in userspace addr to kernel is generally not a great plan.

5. you probably don't need master_create/set ops.

Dave.

Since that message he's also exchanged several more emails on the mailing list with Inki.

It's a different story from what he's said to Qualcomm or Texas Instruments in the past when they have published similar open-source DRM driver code for their ARM SoCs. It's a similar situation to VIA's failed attempts in the past at only partially open-source graphics stacks on Linux.

Let's see what happens here and whether the Samsung DRM driver manages to make it into the mainline Linux kernel.

About The Author
Michael Larabel is the principal author of Phoronix.com and founded the web-site in 2004 with a focus on enriching the Linux hardware experience and being the largest web-site devoted to Linux hardware reviews, particularly for products relevant to Linux gamers and enthusiasts but also commonly reviewing servers/workstations and embedded Linux devices. Michael has written more than 10,000 articles covering the state of Linux hardware support, Linux performance, graphics hardware drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated testing software. He can be followed via and or contacted via .
Latest Linux Hardware Reviews
  1. Acer B286HK: A 28-inch UHD LED 4K Monitor For As Low As $350
  2. Intel Xeon E5-1680 v3 & E5-2687W v3 Compared To The Core i7 5960X On Linux
  3. Intel 120GB 530 Series SSD Linux Performance
  4. Btrfs/EXT4/XFS/F2FS RAID 0/1/5/6/10 Linux Benchmarks On Four SSDs
Latest Linux Articles
  1. Mesa Git Yields Performance Improvements For Newer AMD GPUs
  2. Apple OS X 10.10 vs. Ubuntu 14.10 Performance
  3. Mesa 10.5-devel Brings Some Intel Haswell HD Graphics Changes Over Mesa 10.3
  4. NVIDIA vs. Nouveau Drivers With Linux 3.18 + Mesa 10.4-devel
Latest Linux News
  1. Wine 1.7.32 Updates Its Mono Engine
  2. Mesa 10.4 Release Candidate 3 Is Here For Weekend Testing
  3. GenodeOS 14.11 Now Supports Intel's Wireless Hardware
  4. Jolla Tablet Could Have Upgrades For MicroSDHC, Split Screen, 3.5G
  5. Intel Has Last Round Of DRM Changes For Linux 3.19, Starts Dropping DRI1/UMS
  6. Fedora 21 Release Candidate 1 Awaits Your Testing
  7. GCC 5 Adds Support For ARM's Cortex-A17
  8. KWayland Server Component Coming For KDE Plasma 5.2
  9. NVIDIA Posts Tegra Gallium3D Patch For K1+ Support
  10. Ubuntu 14.10 MacBook Air Tests With Linux 3.18, Mesa 10.5
Latest Forum Discussions
  1. Aliens vs predator for Linux
  2. Updated and Optimized Ubuntu Free Graphics Drivers
  3. Hurrican SDL Port
  4. Roadmap to Catalyst 14.10 ?
  5. how to configure module phoromatic ?
  6. PulseAudio 6.0 Is Coming & Other Linux Audio Plans For The Future
  7. Debian Developer Resigns From The Systemd Maintainership Team
  8. Cant get working Kaveri APU - A10-7850k