1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking Benchmarking Platform
Phoromatic Test Orchestration

Linus On GEM Patches: UNTESTED CRAP

Linux Kernel

Published on 17 October 2008 08:38 PM EDT
Written by Michael Larabel in Linux Kernel
47 Comments

Yesterday we shared that the patches for Intel's GEM (the Graphics Execution Manager) were submitted for inclusion into Linux 2.6.28. Those patches that added in GEM along with a few other Direct Rendering Manager improvements have landed into the mainline Linux git tree, but not without commentary from Linus Torvalds.

Linus became outraged over new DRM warnings and what Linus describes as horribly bad code. Linus is calling out on developers to write cleaner, more readable, and modular code. He describes the Linux 2.6.28 merges thus far as full of "UNTESTED CRAP." The patches being referred to are revised from yesterday with accommodating a few code clean-ups that had since hit the kernel tree along with a CVE fix (David Airlie's mailing list message).

While Linus accepted these important patches into the kernel that provide a memory manager for use by graphics drivers, he did provide a clean-up patch. His comments can be found on the dri-devel mailing list. This isn't the first time Linus has been enraged by DRM patches but back in August he had denied patches citing them as "TOO F*CKING LATE" in the Linux 2.6.27 development cycle.

About The Author
Michael Larabel is the principal author of Phoronix.com and founded the web-site in 2004 with a focus on enriching the Linux hardware experience and being the largest web-site devoted to Linux hardware reviews, particularly for products relevant to Linux gamers and enthusiasts but also commonly reviewing servers/workstations and embedded Linux devices. Michael has written more than 10,000 articles covering the state of Linux hardware support, Linux performance, graphics hardware drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated testing software. He can be followed via and or contacted via .
Latest Linux News
  1. Mesa Git OpenGL Tests With Intel Ivy Bridge Graphics
  2. Blender 2.75 Allows For AMD OpenCL Support
  3. GNOME's Mutter 3.17.2 Adds X11/Wayland Clipboard Interoperation
  4. Wayland 1.8 RC2 Arrives Along With New Weston Compositor Release
  5. LLVM 3.7 Is Planned For A Late August Release
  6. The OpenGL ES 3.1 Foundation Is Being Laid In Mesa
  7. There Are 140k Benchmark Results So Far On LinuxBenchmarking.com
  8. LLVM 3.6.1 Brings R600 & MIPS Fixes
  9. Friction Building Around An Ubuntu Community Council Decision
  10. Bye Bye Mandriva, She's Being Liquidated
Latest Articles & Reviews
  1. Opening The Gates To Our Daily Open-Source Linux Benchmark Results
  2. The Latest Features For Linux Performance Management + Benchmark Monitoring
  3. Noctua NH-U12DX i4 + NF-F12
  4. Btrfs RAID 0/1 Benchmarks On The Linux 4.1 Kernel
Most Viewed News This Week
  1. The Linux 4.0 EXT4 RAID Corruption Bug Has Been Uncovered
  2. NVIDIA's Proprietary Driver Is Moving Closer With Kernel Mode-Setting
  3. Systemd 220 Has Finally Been Released
  4. Microsoft Open-Sources The Windows Communication Foundation
  5. Zapcc Claims To Be A "Much Faster C++ Compiler"
  6. LibreOffice 5.0 Beta 1 Released
  7. Another HTTPS Vulnerability Rattles The Internet
  8. LibreOffice 5.0 Open-Source Office Suite Has Been Branched