1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking Benchmarking Platform
Phoromatic Test Orchestration

Linus On GEM Patches: UNTESTED CRAP

Linux Kernel

Published on 17 October 2008 08:38 PM EDT
Written by Michael Larabel in Linux Kernel
47 Comments

Yesterday we shared that the patches for Intel's GEM (the Graphics Execution Manager) were submitted for inclusion into Linux 2.6.28. Those patches that added in GEM along with a few other Direct Rendering Manager improvements have landed into the mainline Linux git tree, but not without commentary from Linus Torvalds.

Linus became outraged over new DRM warnings and what Linus describes as horribly bad code. Linus is calling out on developers to write cleaner, more readable, and modular code. He describes the Linux 2.6.28 merges thus far as full of "UNTESTED CRAP." The patches being referred to are revised from yesterday with accommodating a few code clean-ups that had since hit the kernel tree along with a CVE fix (David Airlie's mailing list message).

While Linus accepted these important patches into the kernel that provide a memory manager for use by graphics drivers, he did provide a clean-up patch. His comments can be found on the dri-devel mailing list. This isn't the first time Linus has been enraged by DRM patches but back in August he had denied patches citing them as "TOO F*CKING LATE" in the Linux 2.6.27 development cycle.

About The Author
Michael Larabel is the principal author of Phoronix.com and founded the web-site in 2004 with a focus on enriching the Linux hardware experience and being the largest web-site devoted to Linux hardware reviews, particularly for products relevant to Linux gamers and enthusiasts but also commonly reviewing servers/workstations and embedded Linux devices. Michael has written more than 10,000 articles covering the state of Linux hardware support, Linux performance, graphics hardware drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated testing software. He can be followed via and or contacted via .
Latest Articles & Reviews
  1. Sub-$20 802.11n USB WiFi Adapter That's Linux Friendly
  2. The Lenovo T450s Is Working Beautifully With Linux
  3. Linux 4.0 SSD EXT4 / Btrfs / XFS / F2FS Benchmarks
  4. Linux 4.0 Hard Drive Comparison With Six File-Systems
  5. Lenovo ThinkPad T450s Broadwell Preview
  6. How Open-Source Allowed Valve To Implement VULKAN Much Faster On The Source 2 Engine
Latest Linux News
  1. AMD Open-Sources "Addrlib" From Catalyst
  2. AMD Releases New "AMDGPU" Linux Kernel Driver & Mesa Support
  3. A Gigabyte Sandy/Ivy Bridge Motherboard Now Handled By Coreboot
  4. Linux 3.16 Through Linux 4.0 Performance Benchmarks
  5. Intel's Windows Driver Now Supports OpenGL 4.4, Linux Driver Still With OpenGL 3.3
  6. DRM Graphics Updates Sent In For The Linux 4.1 Kernel
  7. More eBPF Improvements Heading To Linux 4.1
  8. LLDB Is Getting Into Shape For Linux 64-bit Debugging
  9. Wine-Staging 1.7.41 Works On Improved Debugging Support
  10. GNOME 3.18 Release Schedule: 23 September Release
Most Viewed News This Week
  1. Nouveau: NVIDIA's New Hardware Is "VERY Open-Source Unfriendly"
  2. LibreOffice 4.5 Bumped To Become LibreOffice 5.0
  3. Linux Audio Is Being Further Modernized With The 4.1 Kernel
  4. KDBUS Is Taking A Lot Of Heat, Might Be Delayed From Mainline Linux Kernel
  5. VirtualBox 5.0 Beta 2 Released
  6. ZFS & Libdvdcss Should Soon Be In Debian
  7. Ubuntu 15.04 Now Under Final Freeze
  8. EXT4 In Linux 4.1 Adds File-System Level Encryption