1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking.org

Linus On GEM Patches: UNTESTED CRAP

Linux Kernel

Published on 17 October 2008 08:38 PM EDT
Written by Michael Larabel in Linux Kernel
47 Comments

Yesterday we shared that the patches for Intel's GEM (the Graphics Execution Manager) were submitted for inclusion into Linux 2.6.28. Those patches that added in GEM along with a few other Direct Rendering Manager improvements have landed into the mainline Linux git tree, but not without commentary from Linus Torvalds.

Linus became outraged over new DRM warnings and what Linus describes as horribly bad code. Linus is calling out on developers to write cleaner, more readable, and modular code. He describes the Linux 2.6.28 merges thus far as full of "UNTESTED CRAP." The patches being referred to are revised from yesterday with accommodating a few code clean-ups that had since hit the kernel tree along with a CVE fix (David Airlie's mailing list message).

While Linus accepted these important patches into the kernel that provide a memory manager for use by graphics drivers, he did provide a clean-up patch. His comments can be found on the dri-devel mailing list. This isn't the first time Linus has been enraged by DRM patches but back in August he had denied patches citing them as "TOO F*CKING LATE" in the Linux 2.6.27 development cycle.

About The Author
Michael Larabel is the principal author of Phoronix.com and founded the web-site in 2004 with a focus on enriching the Linux hardware experience and being the largest web-site devoted to Linux hardware reviews, particularly for products relevant to Linux gamers and enthusiasts but also commonly reviewing servers/workstations and embedded Linux devices. Michael has written more than 10,000 articles covering the state of Linux hardware support, Linux performance, graphics hardware drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated testing software. He can be followed via and or contacted via .
Latest Linux Hardware Reviews
  1. Intel Xeon E5-1680 v3 & E5-2687W v3 Compared To The Core i7 5960X On Linux
  2. Intel 120GB 530 Series SSD Linux Performance
  3. Btrfs/EXT4/XFS/F2FS RAID 0/1/5/6/10 Linux Benchmarks On Four SSDs
  4. AMD's Windows Catalyst Driver Remains Largely Faster Than Linux Drivers
Latest Linux Articles
  1. NVIDIA vs. Nouveau Drivers With Linux 3.18 + Mesa 10.4-devel
  2. Is The Open-Source NVIDIA Driver Fast Enough For Steam On Linux Gaming?
  3. Linux 3.18 File-System Performance Minimally Changed But Possible Regressions
  4. AMD Radeon Gallium3D Is Catching Up & Sometimes Beating Catalyst On Linux
Latest Linux News
  1. Gngr: A New Web Browser Focused On Privacy
  2. Linux 3.18 Kernel: Not Much Change With Intel Haswell Performance
  3. More File-System Tests Of The Linux 3.18 Kernel
  4. Using NVIDIA's NVENC On Linux With FFmpeg
  5. There's Talk Again About An "Open To The Core" Ubuntu Laptop
  6. PowerVR SGX Driver Code Gets Leaked
  7. V2 Of KDBUS Published For Linux Kernel Review
  8. VirtualBox 4.3.20 Arrives, Still No Sign Of VirtualBox 4.4
  9. Scientific Linux 6.6 vs. Scientific Linux 7.0 Benchmarks
  10. Qualcomm Looks To Get Into The ARM Server Business
Latest Forum Discussions
  1. Debian Developer Resigns From The Systemd Maintainership Team
  2. Roadmap to Catalyst 14.10 ?
  3. Updated and Optimized Ubuntu Free Graphics Drivers
  4. Cant get working Kaveri APU - A10-7850k
  5. Script for Fan Speed Control
  6. Debian Init System Coupling Vote Results
  7. The Slides Announcing The New "AMDGPU" Kernel Driver
  8. Ubuntu Developers Still Thinking What To Do About Adobe Flash Support