1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking Benchmarking Platform
Phoromatic Test Orchestration

Linus On GEM Patches: UNTESTED CRAP

Linux Kernel

Published on 17 October 2008 08:38 PM EDT
Written by Michael Larabel in Linux Kernel
47 Comments

Yesterday we shared that the patches for Intel's GEM (the Graphics Execution Manager) were submitted for inclusion into Linux 2.6.28. Those patches that added in GEM along with a few other Direct Rendering Manager improvements have landed into the mainline Linux git tree, but not without commentary from Linus Torvalds.

Linus became outraged over new DRM warnings and what Linus describes as horribly bad code. Linus is calling out on developers to write cleaner, more readable, and modular code. He describes the Linux 2.6.28 merges thus far as full of "UNTESTED CRAP." The patches being referred to are revised from yesterday with accommodating a few code clean-ups that had since hit the kernel tree along with a CVE fix (David Airlie's mailing list message).

While Linus accepted these important patches into the kernel that provide a memory manager for use by graphics drivers, he did provide a clean-up patch. His comments can be found on the dri-devel mailing list. This isn't the first time Linus has been enraged by DRM patches but back in August he had denied patches citing them as "TOO F*CKING LATE" in the Linux 2.6.27 development cycle.

About The Author
Michael Larabel is the principal author of Phoronix.com and founded the web-site in 2004 with a focus on enriching the Linux hardware experience and being the largest web-site devoted to Linux hardware reviews, particularly for products relevant to Linux gamers and enthusiasts but also commonly reviewing servers/workstations and embedded Linux devices. Michael has written more than 10,000 articles covering the state of Linux hardware support, Linux performance, graphics hardware drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated testing software. He can be followed via and or contacted via .
Latest Articles & Reviews
  1. Radeon Linux Benchmarks: Catalyst 15.3 Beta vs. Linux 4.0 + Mesa 10.6-devel
  2. Trying Out The Modern Linux Desktops With 4 Monitors + AMD/NVIDIA Graphics
  3. Turning A Basement Into A Big Linux Server Room
  4. NVIDIA's $1000+ GeForce GTX TITAN X Delivers Maximum Linux Performance
  5. OS X 10.10 vs. Ubuntu 15.04 vs. Fedora 21 Tests: Linux Sweeps The Board
  6. The New Place Where Linux Code Is Constantly Being Benchmarked
Latest Linux News
  1. Debian 8.0 Jessie Gets A Release Date
  2. Firefox 37 Coming Today With Heartbeat, HTTPS Bing
  3. OpenIndiana 2015.03 Updates Its Solaris/Illumos Environment
  4. GNOME 3.16 SDK Runtime Now Available
  5. Initial Intel Braxton Support Might Come To Linux 4.1
  6. Why KDE's KWin Doesn't Integrate Weston/QtCompositor For Wayland Support
  7. Clang Now Supports Targeting The NaCl OS
  8. PC-BSD Updates Its Lumina Desktop (v0.8.3)
  9. Fedora 22 Alpha Now Available For AArch64 & PowerPC64
  10. Systemd Developers Did NOT Fork The Linux Kernel
Most Viewed News This Week
  1. The Big Features Of The Linux 4.0 Kernel
  2. Improved OpenCL Support For Blender's Cycles Renderer
  3. Open-Source Driver Fans Will Love NVIDIA's New OpenGL Demo
  4. Allwinner Continues Jerking Around The Open-Source Community
  5. GNOME 3.16 Released: It's Their Best Release Yet
  6. Ubuntu 15.04 Final Beta Released
  7. Nuclide: Facebook's New Unified IDE
  8. LibreOffice Online: A Cloud Version Of LibreOffice