1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking.org

Tux3 Gets Harshly Criticized Over Code Quality

Linux Kernel

Published on 19 May 2014 11:15 AM EDT
Written by Michael Larabel in Linux Kernel
19 Comments

On Friday the Tux3 file-system was called for review and offered to the mainline Linux kernel. Tux3 has been under development for more than six years but it seems that even after all this time and improvements, the code quality still isn't the best and the work is being scrutinized.

XFS developer Dave Chinner came out Sunday afternoon criticizing the Tux3 code. Dave began, "I had a quick look at the code. This is not a code review - it's a message to tell everyone else not to waste their time looking at the code right now..."
The code is a dog's breakfast of #ifdef hackery, stuff that doesn't work (lots of code surrounded by "#if 0"), there's "#if __KERNEL__ ... #else .... #endif" all through the code, etc. The "declarations within code" stuff is just horrible - it's not even used consistently so it just looks like laziness to me. [In other words], the code is an ugly mess and needs a serious amount of cleanup work.

There's also several kernel hacks within the code. One of the long talked about features was also the Tux3 built-in snapshotting capability that's supposed to be superior to ZFS and Btrfs, but Chinner couldn't find any of that code, only some code comments about adding snapshots.

Tux3 Gets Harshly Criticized Over Code Quality


Dave concluded:
Tux3 is just a prototype of a standard journaling filesystem. The tux3 code is still missing large parts of it's intended core functionality and there is nothing to tell us when that might appear. It really appears to me that tux3 is where btrfs was 5-6 years ago - the core of an idea, but a long, long way from being feature complete or production ready. btrfs still doesn't handle ENOSPC well and given that tux3's is following the same development path (BUG on ENOSPC) it doesn't fill me with any confidence that tux3 is going to turn out any better than btrfs in 5 years time.

Really, I don't see how you plan to bring tux3 to be feature complete and production ready in less than 2-3 years. The current code is barely functional at this point and there's still questions that haven't been answered about whether core tux3 functionality can even be made to work properly, let alone integrated effectively.

IMO, it's a waste of time right now asking anyone to review this code for inclusion until it has been cleaned up, the core infrastructure problems have been solved and the core filesystem code is much closer to feature complete.....

Lead Tux3 developer Daniel Phillips has yet to respond to these critical comments. For what it's worth, it was also Dave Chinner in 2012 who was taking shots at EXT4 and Btrfs.

About The Author
Michael Larabel is the principal author of Phoronix.com and founded the web-site in 2004 with a focus on enriching the Linux hardware experience and being the largest web-site devoted to Linux hardware reviews, particularly for products relevant to Linux gamers and enthusiasts but also commonly reviewing servers/workstations and embedded Linux devices. Michael has written more than 10,000 articles covering the state of Linux hardware support, Linux performance, graphics hardware drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated testing software. He can be followed via and or contacted via .
Latest Linux Hardware Reviews
  1. A Walkthrough Of The New 32 System Open-Source Linux Benchmarking Test Farm
  2. Habey MITX-6771: Mini-ITX Board With Quad-Core J1900 Bay Trail
  3. OCZ Vector 150 SSD On Linux
  4. Noctua i4 CPU Cooler: Great For Cooling High-End LGA-2011v3 CPUs
Latest Linux Articles
  1. 17-Way Linux Graphics Card Comparison With Civilization Beyond Earth
  2. AMD Kaveri: Open-Source Radeon Gallium3D vs. Catalyst 14.12 Omega Driver
  3. 12-Way AMD Catalyst 14.12 vs. NVIDIA 346 Series Linux GPU Comparison
  4. AMD Catalyst 14.12 Omega Driver Brings Mixed Results For Linux Users
Latest Linux News
  1. Intel 2.99.917 X.Org Driver Released, 3.0 Release Finally Near
  2. Server-Side XCB Is Being Discussed For The X.Org Server
  3. Adreno A4xx Rendering With Freedreno Takes Shape
  4. Linux 3.19-rc1 Kernel Released Ahead Of Schedule
  5. Civilization: Beyond Earth Linux GPU/Driver Benchmarks
  6. X.Org Server 1.16.3 Released To Fix Security Issues
  7. Linux 3.19 Merge Window Closes Ahead Of Schedule
  8. MIPS R6 Architecture Now Supported By GCC
  9. LowRISC To Feature Tagged Memory & Minion Cores
  10. Intel Skylake Audio Support For Linux 3.19
Latest Forum Discussions
  1. FPS capped on Linux (AMD fglrx drivers)
  2. Speeding up systemd networking service
  3. Major Performance Breakthrough Discovered For Intel's Mesa Driver
  4. Looking for an nVidia GPU, but not sure how well they are supported.
  5. Need some hand holding with upgrading xserver
  6. Are there an app using HSA ?
  7. The New SuperTuxKart Looks Better, But Can Cause GPU/Driver Problems
  8. XLennart: A Game For Systemd Haters With Nothing Better To Do