Tux3 Gets Harshly Criticized Over Code Quality
On Friday the Tux3 file-system was called for review and offered to the mainline Linux kernel. Tux3 has been under development for more than six years but it seems that even after all this time and improvements, the code quality still isn't the best and the work is being scrutinized.
XFS developer Dave Chinner came out Sunday afternoon criticizing the Tux3 code. Dave began, "I had a quick look at the code. This is not a code review - it's a message to tell everyone else not to waste their time looking at the code right now..."
The code is a dog's breakfast of #ifdef hackery, stuff that doesn't work (lots of code surrounded by "#if 0"), there's "#if __KERNEL__ ... #else .... #endif" all through the code, etc. The "declarations within code" stuff is just horrible - it's not even used consistently so it just looks like laziness to me. [In other words], the code is an ugly mess and needs a serious amount of cleanup work.
There's also several kernel hacks within the code. One of the long talked about features was also the Tux3 built-in snapshotting capability that's supposed to be superior to ZFS and Btrfs, but Chinner couldn't find any of that code, only some code comments about adding snapshots.
Tux3 is just a prototype of a standard journaling filesystem. The tux3 code is still missing large parts of it's intended core functionality and there is nothing to tell us when that might appear. It really appears to me that tux3 is where btrfs was 5-6 years ago - the core of an idea, but a long, long way from being feature complete or production ready. btrfs still doesn't handle ENOSPC well and given that tux3's is following the same development path (BUG on ENOSPC) it doesn't fill me with any confidence that tux3 is going to turn out any better than btrfs in 5 years time.
Lead Tux3 developer Daniel Phillips has yet to respond to these critical comments. For what it's worth, it was also Dave Chinner in 2012 who was taking shots at EXT4 and Btrfs.
Latest Linux Hardware Reviews
Latest Linux Articles
Latest Linux News
Latest Forum Discussions