1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking.org

X.Org Security Advisory For X11 Going Back To 1993

X.Org

Published on 09 October 2013 08:12 PM EDT
Written by Michael Larabel in X.Org
27 Comments

An X.Org security advisory was issued this week in regards to authenticated X clients being able to cause the X Server to use memory after it was freed. This particular use-after-free memory issue, which could lead to a system crash and memory corruption, has been present in every X11/X.Org Server release going back to September of 1993.

Alan Coopersmith of Oracle, acting on the behalf of the X.Org Security Team, came out yesterday to publicly make known a security issue reported by Pedro Ribeiro. The issue, officially known as "CVE-2013-4396: Use after free in Xserver handling of ImageText requests", means "an authenticated X client can cause an X server to use memory after it was freed, potentially leading to crash and/or memory corruption."

Use-after-free issues aren't particularly uncommon or as shocking as other security issues in the past like input security problems or the bad screensaver security issue. What makes this security advisory more interesting is how long it's been around.

While this security advisory is of rather low priority, CVE-2013-4396 has been present in the X Server for two decades. The bug was introduced in the RCS version 1.42 on 18 September 1993. Now in October of 2013, this issue was finally patched and will be included as part of the next X.Org Server 1.14 stable point release (1.14.4) and as part of X.Org Server 1.15 -- the next major release due out at the end of the year.

With the appearance of the bug in September 1993, the issue is likely found in every X server release from X11R6.0 up through the modern day X.Org Server 1.14.3 release. While the issue will be addressed in the next X.Org Server updates, there's also a small five-line patch available that takes care of the security advisory.

CVE-2013-4396 can be read on the Xorg mailing list and embedded below is the patch description with additional information on the code issue.
Save a pointer to the passed in closure structure before copying it and overwriting the *c pointer to point to our copy instead of the original. If we hit an error, once we free(c), reset c to point to the original structure before jumping to the cleanup code that references *c.

Since one of the errors being checked for is whether the server was able to malloc(c->nChars * itemSize), the client can potentially pass a number of characters chosen to cause the malloc to fail and the error path to be taken, resulting in the read from freed memory.

Since the memory is accessed almost immediately afterwards, and the X server is mostly single threaded, the odds of the free memory having invalid contents are low with most malloc implementations when not using memory debugging features, but some allocators will definitely overwrite the memory there, leading to a likely crash.

About The Author
Michael Larabel is the principal author of Phoronix.com and founded the web-site in 2004 with a focus on enriching the Linux hardware experience and being the largest web-site devoted to Linux hardware reviews, particularly for products relevant to Linux gamers and enthusiasts but also commonly reviewing servers/workstations and embedded Linux devices. Michael has written more than 10,000 articles covering the state of Linux hardware support, Linux performance, graphics hardware drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated testing software. He can be followed via and or contacted via .
Latest Linux Hardware Reviews
  1. CompuLab Intense-PC2: An Excellent, Fanless, Mini PC Powered By Intel's i7 Haswell
  2. From The Atom 330 To Haswell ULT: Intel Linux Performance Benchmarks
  3. AMD Radeon R9 285 Tonga Performance On Linux
  4. Apotop Wi-Copy
Latest Linux Articles
  1. AMD Moves Forward With Unified Linux Driver Strategy, New Kernel Driver
  2. MSI: Update Your BIOS From The Linux Desktop
  3. NVIDIA vs. AMD 2D Linux Drivers: Catalyst Is Getting Quite Good At 2D
  4. 15-Way GPU Comparison With Mesa 10.3 + Linux 3.17
Latest Linux News
  1. Linux 3.18-rc1 Released One Week Early With Many Changes
  2. The VC4 Gallium3D Driver Is Still Moving Along For The Raspberry Pi
  3. Direct3D 9 Support Might Land Within Mainline Mesa 3D Drivers
  4. OpenGL Preview Benchmarks For NVIDIA's GeForce GTX 970
  5. HOPE: The Ease Of Python With The Speed Of C++
  6. Vitesse: Using LLVM To Speed Up Databases
  7. AMD Is Restructuring Again, Losing 7% Of Employees
  8. Linux Testing Of The NVIDIA GeForce GTX 970
  9. Qt 5.4 Now In Beta With Web, Bluetooth LE, Graphics Improvements
  10. AMD's Radeon R9 285 On Linux Offers Good OpenCL Performance
Latest Forum Discussions
  1. NVIDIA Presents Its Driver Plans To Support Mir/Wayland & KMS On Linux
  2. AMD Is Restructuring Again, Losing 7% Of Employees
  3. Bye bye BSD, Hello Linux: A Sys Admin's Story
  4. Open-Source AMD Fusion E-350 Support Takes A Dive
  5. Upgrade to Kaveri, very slow VDPAU performance
  6. ChromeOS Drops Support For EXT2/EXT3/EXT4 File-Systems
  7. Lennart Poettering On The Open-Source Community: A Sick Place To Be In
  8. The Slides Announcing The New "AMDGPU" Kernel Driver