1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking.org

New Linux CPU Hot-Plugging Works Out "Nightmare"

Linux Kernel

Published on 31 January 2013 03:25 PM EST
Written by Michael Larabel in Linux Kernel
13 Comments

The current Linux kernel CPU hot-plugging support has been described as "an increasing nightmare full of races and undocumented behaviour", but fortunately it's in the process of being re-developed.

Thomas Gleixner has been one of the kernel developers looking to rework the Linux CPU hot-plug support and published a new patch-set today. Hot-plugging support in general has been a focus lately with work on a common system device hot-plug framework for the kernel, true CPU hot-plug support, ACPI hot-plug improvements, and other efforts in recent months.

Gleixner's CPU hot-plug re-work that was published today consists of 40 patches that amount to over one thousand lines of changed code within the kernel. Below is his description of the massive CPU hot-plug changes for the Linux kernel.
The current CPU hotplug implementation has become an increasing nightmare full of races and undocumented behaviour. The main issue of the current hotplug scheme is the completely asymetric startup/teardown process. The hotplug notifiers are mostly undocumented and the CPU_* actions in lots of implementations seem to be randomly chosen.

We had a long discussion in San Diego last year about reworking the hotplug core into a fully symetric state machine. After a few doomed attempts to convert the existing code into a state machine, I finally found a workable solution.

The following patch series implements a trivial array based state machine, which replaces the existing steps in cpu_up/down and also the notifiers which must run on the hotplugged cpu are converted to a callback array. This documents clearly the ordering of the callbacks and also makes the asymetric behaviour very obvious.

This series converts the stop_machine thread to the smpboot infrastructure, implements the core state machine and converts all notifiers which have ordering constraints plus a randomly chosen bunch of other notifiers to the state machine.

The runtime installed callbacks are immediately executed by the core code on or on behalf of all cpus which have already reached the corresponding state. A non executing installer function is there as well to allow simple migration of the existing notifier maze.

The diffstat of the complete series is appended below.

36 files changed, 1300 insertions(+), 1179 deletions(-)

We add slightly more code at this stage (225 lines alone in a header file), but most of the conversions are removing code and we have only tackled about 30 of 130+ instances. Even with the current conversion state, the resulting text size shrinks already.
The current patch-set can be found in CPU hotplug rework - episode I.

About The Author
Michael Larabel is the principal author of Phoronix.com and founded the web-site in 2004 with a focus on enriching the Linux hardware experience and being the largest web-site devoted to Linux hardware reviews, particularly for products relevant to Linux gamers and enthusiasts but also commonly reviewing servers/workstations and embedded Linux devices. Michael has written more than 10,000 articles covering the state of Linux hardware support, Linux performance, graphics hardware drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated testing software. He can be followed via and or contacted via .
Latest Linux Hardware Reviews
  1. A Walkthrough Of The New 32 System Open-Source Linux Benchmarking Test Farm
  2. Habey MITX-6771: Mini-ITX Board With Quad-Core J1900 Bay Trail
  3. OCZ Vector 150 SSD On Linux
  4. Noctua i4 CPU Cooler: Great For Cooling High-End LGA-2011v3 CPUs
Latest Linux Articles
  1. AMD Kaveri: Open-Source Radeon Gallium3D vs. Catalyst 14.12 Omega Driver
  2. 12-Way AMD Catalyst 14.12 vs. NVIDIA 346 Series Linux GPU Comparison
  3. AMD Catalyst 14.12 Omega Driver Brings Mixed Results For Linux Users
  4. 6-Way Winter 2014 Linux Distribution Comparison
Latest Linux News
  1. That Nasty Linux Kernel Lockup Bug Is Still Unresolved
  2. KDE's Krita Loses Its Main Backer
  3. Inline Data Support Comes To CephFS With Linux 3.19
  4. VC4 Gallium3D Adds DMA-BUF Support, Yields Working DRI3
  5. GNOME Builder Is Still Building Up To A New IDE For Developers
  6. Raspberry Pi's Gallium3D Driver Could Now Run Significantly Faster
  7. CMake 3.1 Brings Windows Additions, Target Compile Feature
  8. KDE Applications 14.12 Released
  9. Fedora 21 Released For POWER & AArch64 Hardware
  10. Elasticsearch & wxPython 3 Proposed For Fedora 22
Latest Forum Discussions
  1. Bench specific mount point
  2. XLennart: A Game For Systemd Haters With Nothing Better To Do
  3. Tool for measuring FPS in games
  4. Need some hand holding with upgrading xserver
  5. Ubuntu Developers Still Thinking What To Do About Adobe Flash Support
  6. Microsoft buying Mojang
  7. Updated and Optimized Ubuntu Free Graphics Drivers
  8. Premium subscription "login" times out much faster than forum