1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking.org

New Linux CPU Hot-Plugging Works Out "Nightmare"

Linux Kernel

Published on 31 January 2013 03:25 PM EST
Written by Michael Larabel in Linux Kernel
13 Comments

The current Linux kernel CPU hot-plugging support has been described as "an increasing nightmare full of races and undocumented behaviour", but fortunately it's in the process of being re-developed.

Thomas Gleixner has been one of the kernel developers looking to rework the Linux CPU hot-plug support and published a new patch-set today. Hot-plugging support in general has been a focus lately with work on a common system device hot-plug framework for the kernel, true CPU hot-plug support, ACPI hot-plug improvements, and other efforts in recent months.

Gleixner's CPU hot-plug re-work that was published today consists of 40 patches that amount to over one thousand lines of changed code within the kernel. Below is his description of the massive CPU hot-plug changes for the Linux kernel.
The current CPU hotplug implementation has become an increasing nightmare full of races and undocumented behaviour. The main issue of the current hotplug scheme is the completely asymetric startup/teardown process. The hotplug notifiers are mostly undocumented and the CPU_* actions in lots of implementations seem to be randomly chosen.

We had a long discussion in San Diego last year about reworking the hotplug core into a fully symetric state machine. After a few doomed attempts to convert the existing code into a state machine, I finally found a workable solution.

The following patch series implements a trivial array based state machine, which replaces the existing steps in cpu_up/down and also the notifiers which must run on the hotplugged cpu are converted to a callback array. This documents clearly the ordering of the callbacks and also makes the asymetric behaviour very obvious.

This series converts the stop_machine thread to the smpboot infrastructure, implements the core state machine and converts all notifiers which have ordering constraints plus a randomly chosen bunch of other notifiers to the state machine.

The runtime installed callbacks are immediately executed by the core code on or on behalf of all cpus which have already reached the corresponding state. A non executing installer function is there as well to allow simple migration of the existing notifier maze.

The diffstat of the complete series is appended below.

36 files changed, 1300 insertions(+), 1179 deletions(-)

We add slightly more code at this stage (225 lines alone in a header file), but most of the conversions are removing code and we have only tackled about 30 of 130+ instances. Even with the current conversion state, the resulting text size shrinks already.
The current patch-set can be found in CPU hotplug rework - episode I.

About The Author
Michael Larabel is the principal author of Phoronix.com and founded the web-site in 2004 with a focus on enriching the Linux hardware experience and being the largest web-site devoted to Linux hardware reviews, particularly for products relevant to Linux gamers and enthusiasts but also commonly reviewing servers/workstations and embedded Linux devices. Michael has written more than 10,000 articles covering the state of Linux hardware support, Linux performance, graphics hardware drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated testing software. He can be followed via and or contacted via .
Latest Linux Hardware Reviews
  1. ROCCAT LUA: A Linux-Friendly Gaming Mouse
  2. Cheetah Mounts: The Affordable Way To Put Your TV On The Wall
  3. Scythe Mugen MAX
  4. Intel Core i7 5960X Haswell-E On Linux
Latest Linux Articles
  1. Preview: Radeon Gallium3D Performance For CS:GO On Linux
  2. XWayland Linux Gaming Performance With GNOME Wayland On Fedora 21
  3. EXT4/Btrfs/XFS/F2FS Benchmarks On Linux 3.17
  4. Fedora 21 Alpha First Impressions: It's Great
Latest Linux News
  1. Operating System U Fails To Live Up To Its Goals
  2. AMD Catalyst 14.9 Officially Released For Linux
  3. Nouveau Memory Re-Clocking Comes For More NVIDIA GPUs
  4. NVIDIA Suggests Explicit Synchronization For Nouveau
  5. Adobe Brings Streaming Photoshop To Chromebooks
  6. OverlayFS Proposed For The Linux 3.18 Kernel
  7. NVIDIA To Issue An Update On Their Support Of Mir & Wayland
  8. NVIDIA Is Still Working On The New Linux OpenGL ABI
  9. Intel Haswell HD Graphics With CS:GO On Linux
  10. The Most Dominating Linux Stories Of Q3'2014
Latest Forum Discussions
  1. New AMD Catalyst drivers out today
  2. NVIDIA Alerts Nouveau: They're Starting To Sign/Validate GPU Firmware Images
  3. Updated and Optimized Ubuntu Free Graphics Drivers
  4. Take the Steam Survey results with a grain of salt. It is flawed.
  5. FSF Issues Statement On Shellshock Bash Vulnerability
  6. AMD Wants To Know What's Wrong With Catalyst
  7. New Group Calls For Boycotting Systemd
  8. Counter-Strike: Global Offensive NVIDIA/AMD Benchmarks On Linux