1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking.org

X.Org: "A Wasteland of Unreviewedness"

X.Org

Published on 17 May 2012 04:06 AM EDT
Written by Michael Larabel in X.Org
9 Comments

After David Airlie brought up the new DDX driver API for the X.Org Server, a new discussion was born concerning the lack of patch review taking place for the X.Org Server.

David Airlie commented on the developers' mailing list about the lack of patch review for the new API patches, he wonders how he's "going to get the next 50 patches in at this rate some time this year." Alan Coopersmith then responded with how there seems to be a harder time overall in getting patch reviews done. Coopersmith says, "I've got no ideas how to fix this quickly, but we need to get it fixed."

The Oracle X.Org developer started a new mailing list thread about the lack of reviews. David Airlie went on to comment:
I've pretty much no idea how to deal with it sanely. We've moved to larger scale development model without a larger set of developers. The kernel isn't even as stringent wrt to reviews as xorg-devel is.

I'm guessing we'll probably have to have review swap parties or meetings or something insane like that to clear the backlog on occasions, it would be nice if patchwork could be kept up to date, but it would involve anyone handling patches to jump on and clean up the ones they've merged already.

I spent a major amount of my time either reviewing kernel patches, or persuading others to review other peoples patches so I don't have to, I'm not sure if we need some more tracking from Keith or others on what unreviewed stuff is outstanding and who best to direct it to, but again it involves a time commitment from someone and I've no idea who could afford it.

Like the input guys have a bit of crossover work, the build system stuff seems to be covered, but the rest of the server is a wasteland of unreviewedness.

Keith Packard's response to this wasteland of unreviewedness was, "Small changes seem to get reviewed pretty quickly; it's big changes that take actual thought that just aren't getting looked at quickly (if at all)."

Peter Hutterer's response is in favor of loosening the review requirements for xorg-server code. Alan Coopersmith also re-sent some patches that have been sent to the list before, but went un-reviewed, so if no one steps up to the plate, he's just going to be sending patches un-reviewed for merging.

But, on the plus side, the rants got Aaron Plattner of NVIDIA to review the first four patches of David Airlie's for the driver API changes, per this message.

Latest Linux Hardware Reviews
  1. 13-Way Low-End GPU Comparison With AMD's AM1 Athlon
  2. ASUS AM1I-A: A Mini-ITX Board For Socketed Kabini APUs
  3. Mini-Box M350: A Simple, Affordable Mini-ITX Case
  4. Overclocking The AMD AM1 Athlon & Sempron APUs
Latest Linux Articles
  1. Ubuntu 12.04.4 vs. 13.10 vs. 14.04 LTS Desktop Benchmarks
  2. AMD OpenCL Performance With AM1 Kabini APUs
  3. A Quick Look At GCC 4.9 vs. LLVM Clang 3.5
  4. Are AMD Athlon/Sempron APUs Fast Enough For Steam On Linux?
Latest Linux News
  1. The Improv ARM Board Still Isn't Shipping; Riding A Dead Horse?
  2. Debian To Maintain 6.0 Squeeze As An LTS Release
  3. Wasteland 2 Is Finally Released For Linux Gamers
  4. FreeBSD Advances For ARM, Bhyve, Clang
  5. Ubuntu 14.04 LTS "Trusty Tahr" Officially Released
  6. Ubuntu 12.04 LTS vs. 14.04 LTS Server Benchmarks
  7. QEMU 2.0 Released With ARM, x86 Enhancements
  8. Running The Unity 8 Preview Session On Ubuntu 14.04 LTS
  9. R600 Gallium3D Disables LLVM Back-End By Default
  10. Fedora 21 Gets GNOME 3.12, PHP 5.6, Mono 3.4
  11. Fedora Workstation Is Making Me Quite Excited
  12. Maynard: A Lightweight Wayland Desktop
Latest Forum Discussions
  1. The GNOME Foundation Is Running Short On Money
  2. Updated and Optimized Ubuntu Free Graphics Drivers
  3. Radeon 8000M problematic on Linux?
  4. Linux Kernel Developers Fed Up With Ridiculous Bugs In Systemd
  5. After Jack Keane, RuseSoft will briing Ankh 3 to Linux through Desura
  6. Suspected PHP Proxy Issue
  7. Change installation destination from home directory
  8. Bye bye BSD, Hello Linux: A Sys Admin's Story