1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking.org

X.Org: "A Wasteland of Unreviewedness"

X.Org

Published on 17 May 2012 04:06 AM EDT
Written by Michael Larabel in X.Org
9 Comments

After David Airlie brought up the new DDX driver API for the X.Org Server, a new discussion was born concerning the lack of patch review taking place for the X.Org Server.

David Airlie commented on the developers' mailing list about the lack of patch review for the new API patches, he wonders how he's "going to get the next 50 patches in at this rate some time this year." Alan Coopersmith then responded with how there seems to be a harder time overall in getting patch reviews done. Coopersmith says, "I've got no ideas how to fix this quickly, but we need to get it fixed."

The Oracle X.Org developer started a new mailing list thread about the lack of reviews. David Airlie went on to comment:
I've pretty much no idea how to deal with it sanely. We've moved to larger scale development model without a larger set of developers. The kernel isn't even as stringent wrt to reviews as xorg-devel is.

I'm guessing we'll probably have to have review swap parties or meetings or something insane like that to clear the backlog on occasions, it would be nice if patchwork could be kept up to date, but it would involve anyone handling patches to jump on and clean up the ones they've merged already.

I spent a major amount of my time either reviewing kernel patches, or persuading others to review other peoples patches so I don't have to, I'm not sure if we need some more tracking from Keith or others on what unreviewed stuff is outstanding and who best to direct it to, but again it involves a time commitment from someone and I've no idea who could afford it.

Like the input guys have a bit of crossover work, the build system stuff seems to be covered, but the rest of the server is a wasteland of unreviewedness.

Keith Packard's response to this wasteland of unreviewedness was, "Small changes seem to get reviewed pretty quickly; it's big changes that take actual thought that just aren't getting looked at quickly (if at all)."

Peter Hutterer's response is in favor of loosening the review requirements for xorg-server code. Alan Coopersmith also re-sent some patches that have been sent to the list before, but went un-reviewed, so if no one steps up to the plate, he's just going to be sending patches un-reviewed for merging.

But, on the plus side, the rants got Aaron Plattner of NVIDIA to review the first four patches of David Airlie's for the driver API changes, per this message.

About The Author
Michael Larabel is the principal author of Phoronix.com and founded the web-site in 2004 with a focus on enriching the Linux hardware experience and being the largest web-site devoted to Linux hardware reviews, particularly for products relevant to Linux gamers and enthusiasts but also commonly reviewing servers/workstations and embedded Linux devices. Michael has written more than 10,000 articles covering the state of Linux hardware support, Linux performance, graphics hardware drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated testing software. He can be followed via and or contacted via .
Latest Linux Hardware Reviews
  1. NVIDIA GeForce GTX 970 Offers Great Linux Performance
  2. CompuLab Intense-PC2: An Excellent, Fanless, Mini PC Powered By Intel's i7 Haswell
  3. From The Atom 330 To Haswell ULT: Intel Linux Performance Benchmarks
  4. AMD Radeon R9 285 Tonga Performance On Linux
Latest Linux Articles
  1. AMD Moves Forward With Unified Linux Driver Strategy, New Kernel Driver
  2. MSI: Update Your BIOS From The Linux Desktop
  3. NVIDIA vs. AMD 2D Linux Drivers: Catalyst Is Getting Quite Good At 2D
  4. 15-Way GPU Comparison With Mesa 10.3 + Linux 3.17
Latest Linux News
  1. Linux 3.19 To Have Skylake Graphics, PPGTT Enablement
  2. Ubuntu 16.04 Might Be The Distribution's Last 32-Bit Release
  3. Imagination Releases Full ISA Documentation For PowerVR Rogue GPUs
  4. Features GNOME Developers Want In The Linux Kernel
  5. GTK+ Gains Experimental Overlay Scrollbars
  6. Phoronix Test Suite 5.4 M3 Is Another Hearty Update
  7. GParted 0.20 Improves Btrfs Support
  8. EXT4 In Linux 3.18 Has Clean-ups, Bug Fixes
  9. Emacs 24.4 Has Built-In Web Browser, Improved Multi-Monitor Support
  10. NVIDIA's NVPTX Support For GCC Is Close To Being Merged
Latest Forum Discussions
  1. Users/Developers Threatening Fork Of Debian GNU/Linux
  2. HOPE: The Ease Of Python With The Speed Of C++
  3. Proof that strlcpy is un-needed
  4. Bye bye BSD, Hello Linux: A Sys Admin's Story
  5. Updated and Optimized Ubuntu Free Graphics Drivers
  6. NVIDIA Presents Its Driver Plans To Support Mir/Wayland & KMS On Linux
  7. AMD Is Restructuring Again, Losing 7% Of Employees
  8. Open-Source AMD Fusion E-350 Support Takes A Dive