1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking.org

X.Org: "A Wasteland of Unreviewedness"

X.Org

Published on 17 May 2012 04:06 AM EDT
Written by Michael Larabel in X.Org
9 Comments

After David Airlie brought up the new DDX driver API for the X.Org Server, a new discussion was born concerning the lack of patch review taking place for the X.Org Server.

David Airlie commented on the developers' mailing list about the lack of patch review for the new API patches, he wonders how he's "going to get the next 50 patches in at this rate some time this year." Alan Coopersmith then responded with how there seems to be a harder time overall in getting patch reviews done. Coopersmith says, "I've got no ideas how to fix this quickly, but we need to get it fixed."

The Oracle X.Org developer started a new mailing list thread about the lack of reviews. David Airlie went on to comment:
I've pretty much no idea how to deal with it sanely. We've moved to larger scale development model without a larger set of developers. The kernel isn't even as stringent wrt to reviews as xorg-devel is.

I'm guessing we'll probably have to have review swap parties or meetings or something insane like that to clear the backlog on occasions, it would be nice if patchwork could be kept up to date, but it would involve anyone handling patches to jump on and clean up the ones they've merged already.

I spent a major amount of my time either reviewing kernel patches, or persuading others to review other peoples patches so I don't have to, I'm not sure if we need some more tracking from Keith or others on what unreviewed stuff is outstanding and who best to direct it to, but again it involves a time commitment from someone and I've no idea who could afford it.

Like the input guys have a bit of crossover work, the build system stuff seems to be covered, but the rest of the server is a wasteland of unreviewedness.

Keith Packard's response to this wasteland of unreviewedness was, "Small changes seem to get reviewed pretty quickly; it's big changes that take actual thought that just aren't getting looked at quickly (if at all)."

Peter Hutterer's response is in favor of loosening the review requirements for xorg-server code. Alan Coopersmith also re-sent some patches that have been sent to the list before, but went un-reviewed, so if no one steps up to the plate, he's just going to be sending patches un-reviewed for merging.

But, on the plus side, the rants got Aaron Plattner of NVIDIA to review the first four patches of David Airlie's for the driver API changes, per this message.

About The Author
Michael Larabel is the principal author of Phoronix.com and founded the web-site in 2004 with a focus on enriching the Linux hardware experience and being the largest web-site devoted to Linux hardware reviews, particularly for products relevant to Linux gamers and enthusiasts but also commonly reviewing servers/workstations and embedded Linux devices. Michael has written more than 10,000 articles covering the state of Linux hardware support, Linux performance, graphics hardware drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated testing software. He can be followed via and or contacted via .
Latest Articles & Reviews
  1. Linux Compiler Benchmarks Of LLVM Clang 3.5 vs. LLVM Clang 3.6-rc1
  2. Intel Broadwell HD Graphics 5500: Windows 8.1 vs. Linux
  3. Linux Benchmarks Of NVIDIA's Early 2015 GeForce Line-Up
  4. NVIDIA GeForce GTX 960: A Great $200 GPU For Linux Gamers
  5. Disk Encryption Tests On Fedora 21
  6. Xonotic 0.8 Performance With The Open-Source AMD/NVIDIA Gallium3D Drivers
Latest Linux News
  1. LibreOffice 4.4 Is Coming Soon With New Features
  2. How To Use GCC 5's OpenMP & OpenACC Offloading Support
  3. Linux Users Upset By Chromium's Busted HiDPI Support
  4. BPF Backend Merged Into LLVM To Make Use Of New Kernel Functionality
  5. Dying Light Is Headed To Linux, SteamOS
  6. Wayland 1.6.1 & Weston 1.6.1 Released
  7. Mesa 10.4.3 Brings A Bunch Of Fixes For The Direct3D "Nine" Support
  8. Intel Has A Few More Graphics Changes For The Linux 3.20 Kernel
  9. Gummiboot Gains PE File Searching Support To Find Linux Kernels
  10. Wine 1.7.35 Starts Working On OpenGL Core Context Support
Most Viewed News This Week
  1. Windows 10 To Be A Free Upgrade: What Linux Users Need To Know
  2. CoreOS Moves From Btrfs To EXT4 + OverlayFS
  3. Google Admin Encourages Trying Btrfs, Not ZFS On Linux
  4. TraceFS: The Newest Linux File-System
  5. Mozilla's Servo Still On Track For 2015 Alpha Release
  6. My Initial Intel Broadwell Linux Experience With The ThinkPad X1 Carbon
  7. Fedora 23 Likely To Pursue Wayland By Default
  8. Keith Packard Leaves Intel's Linux Graphics Work