1. Computers
  2. Display Drivers
  3. Graphics Cards
  4. Memory
  5. Motherboards
  6. Processors
  7. Software
  8. Storage
  9. Operating Systems


Facebook RSS Twitter Twitter Google Plus


Phoronix Test Suite

OpenBenchmarking.org

Another Linus Rant About Linux DRM; Rejects Pull

Linux Kernel

Published on 06 December 2011 05:11 PM EST
Written by Michael Larabel in Linux Kernel
11 Comments

Linus Torvalds is known to make a few colorful remarks from time to time. Today he's become frustrated once again with the Linux DRM layer and has rejected a pull request for the Linux 3.2 kernel.

David Airlie had sent in a pull request today for the Linux 3.2 kernel that addresses an Intel VT-d issue with Ironlake graphics, a kexec fix where the GPU write-back engines need to be switched off, and then a trivial Radeon KMS fix. The kexec fix sent Linus over the edge.

In the past Linus Torvalds has been vocal about select Direct Rendering Manager (DRM) pull requests from David Airlie with calling the GEM memory management patches at first being untested crap, the lack of Nouveau DRM in the Linux kernel, questioning what's wrong with the whole DRM crowd, and showing why DRM has been problematic (late pull request), among other remarks.

Below is the response from Linus Torvalds for Airlie's pull request.
Quite frankly, I think it's too late for something like a kexec bugfix. Nobody cares. So kexec doesn't work - that's not something new. This doesn't smell like a regression to me. And the kcalloc things you mention *sound* like some kind of cleanup crap.

The DRM layer has been fairly good for a few releases, but I'm getting the feeling that I need to start pushing back, because I'm getting stuff that I don't think matters, and shouldn't be sent to me after -rc4.

So I'm not pulling this.

What the heck is up?

By now, I want fixes that either fix real regressions that people *care* about, or that help new unreleased hardware that people *will* care about and that cannot possibly mess up old users.

kexec? Who the f*ck cares? Really?

Linus

As it's not exactly a popular end-user Linux feature, for those that don't known, kexec allows a new kernel to be booted and switched to from an existing running Linux kernel without a full system reboot. Using kexec skips over the BIOS/UEFI hardware initialization -- this allows for a faster switch to a new kernel and other niche cases (e.g. there's a way to re-clock with the NVIDIA binary blob and then switching over to Nouveau, etc).

After Airlie replied to Linus, there was a soft response from Torvalds where he clarified his position.
So having looked at the patch itself, I don't dislike the notion of making sure certain fields are nicely initialized. So I don't hate the patch itself, but quite frankly, to me it doesn't smell even *remotely* like "regression fix". I don't think this is something that has ever worked.

And I do realize that some enterprise distros want to use kexec, but at the same time I say "that's *their* problem". We know kexec hasn't been horribly reliable, anybody who uses it should have be taking that into account.

I hope kexec gets more reliable, but I *also* really hope that our RC series will calm down, and on the whole, weighing the two concerns, when we're talking about something that has never worked before either, I think the thing is pretty clear.

That said, if there is some other real use-case ("this fixes problems with the BIOS from Xyz initializing things to random crap"), I'd have no real objections to the patch itself.

So my complaint is really a "I want to be more anal about the later -rc patches, I feel we're slipping", not a "I hate the patch per se".

Linus

Linus is basically wanting to reserve the post merge window now for "real" regression fixes and new hardware enablement, at least for the DRM subsystem.

The thread can be found on LKML.org for those wanting to read in full or check for updates.

About The Author
Michael Larabel is the principal author of Phoronix.com and founded the web-site in 2004 with a focus on enriching the Linux hardware experience and being the largest web-site devoted to Linux hardware reviews, particularly for products relevant to Linux gamers and enthusiasts but also commonly reviewing servers/workstations and embedded Linux devices. Michael has written more than 10,000 articles covering the state of Linux hardware support, Linux performance, graphics hardware drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated testing software. He can be followed via and or contacted via .
Latest Linux Hardware Reviews
  1. Trying The Configurable 45 Watt TDP With AMD's A10-7800 / A6-7400K
  2. Sumo's Omni Gets Reloaded
  3. AMD A10-7800 & A6-7400K APUs Run Great On Linux
  4. Radeon Gallium3D Is Running Increasingly Well Against AMD's Catalyst Driver
Latest Linux Articles
  1. AMD's RadeonSI Driver Sped Up A Lot This Summer
  2. Intel's Latest Linux Graphics Code Competes Against OS X 10.9
  3. Intel Sandy Bridge Gets A Surprise Boost From Linux 3.17
  4. Open-Source Radeon Graphics Have Some Improvements On Linux 3.17
Latest Linux News
  1. The Widely-Criticized New Commercial Linux Distro Is Now On Kickstarter
  2. CUDA 6.5 Is Doing Great For Blender
  3. Wayland & Weston 1.6 Alpha Released
  4. Nouveau Gets Improved Re-Clocking Handling For Select GPUs
  5. A New First-Person Mystery Game Might Be Coming To Linux
  6. Patch By Patch, LLVM Clang Gets Better At Building The Linux Kernel
  7. VC4 Gallium3D Driver Now Handles X With GLAMOR
  8. Opera 25 Development Release For Linux
  9. Steam Now Supports VA-API For In-Home Game Streaming
  10. GNOME 3.14 Beta Released
Latest Forum Discussions
  1. Systemd 216 Piles On More Features, Aims For New User-Space VT
  2. OSS radeon driver for A10-7850K (Kaveri)
  3. Btrfs Gets Talked Up, Googler Encourages You To Try Btrfs
  4. American Citizens running AMOK for food stamps
  5. What Linux Distribution Should Be Benchmarked The Most?
  6. Company I work for is looking to contribute to Open Source projects... but wrongly?
  7. Microsoft vs. Campaign
  8. Updated and Optimized Ubuntu Free Graphics Drivers