Page 1 of 3 123 LastLast
Results 1 to 10 of 26

Thread: Valgrind Finds Thousands Of Potential Issues With Mesa

  1. #1
    Join Date
    Jan 2007
    Posts
    14,805

    Default Valgrind Finds Thousands Of Potential Issues With Mesa

    Phoronix: Valgrind Finds Thousands Of Potential Issues With Mesa

    An open-source developer has spotted thousands of potential memory problems with Mesa when using Valgrind...

    http://www.phoronix.com/vr.php?view=MTQzNjk

  2. #2
    Join Date
    Aug 2012
    Posts
    458

    Default

    "David Airlie has been the only Mesa contributor to respond to the Mesa Valgrind posting yet and he suggests some of the errors may be due to kernel ioctls not known by Valgrind. "We access a lot of kernel data via ioctls that valgrind doesn't understand. I'm not saying that is definitely the case but it was in a lot of places."

    Wow, just wow.

    Instead of saying thank you for finding these problems and calling all available programmers to help the debug, the only poster basically says "there isn't any bugs, your program isn't working right, we're prefect and incapable of generating bugs for we're gods. 100% your fault".

    And these people make the drivers? That should scare you a bit. Humility is a good feature in a person, not a bad one

  3. #3
    Join Date
    Nov 2008
    Location
    Old Europe
    Posts
    916

    Default

    Quote Originally Posted by dh04000 View Post
    "David Airlie has been the only Mesa contributor to respond to the Mesa Valgrind posting yet and he suggests some of the errors may be due to kernel ioctls not known by Valgrind. "We access a lot of kernel data via ioctls that valgrind doesn't understand. I'm not saying that is definitely the case but it was in a lot of places."

    Wow, just wow.

    Instead of saying thank you for finding these problems and calling all available programmers to help the debug, the only poster basically says "there isn't any bugs, your program isn't working right, we're prefect and incapable of generating bugs for we're gods. 100% your fault".

    And these people make the drivers? That should scare you a bit. Humility is a good feature in a person, not a bad one
    You are seriously lacking reading skills, dude.
    Or you're just a f**king troll.

  4. #4
    Join Date
    Mar 2013
    Posts
    6

    Default

    Quote Originally Posted by dh04000 View Post
    Wow, just wow.

    Instead of saying thank you for finding these problems and calling all available programmers to help the debug, the only poster basically says "there isn't any bugs, your program isn't working right, we're prefect and incapable of generating bugs for we're gods. 100% your fault".

    And these people make the drivers? That should scare you a bit. Humility is a good feature in a person, not a bad one
    No, he didn't. He simply said that valgrind might be detecting code it doesn't reconize properly as bugs. Nothing else.

    He never even mentioned the other guy's code. I don't get how you reached the conclusion that he lacks humility unless you're trolling.

  5. #5
    Join Date
    Oct 2007
    Posts
    1,274

    Default

    Quote Originally Posted by dh04000 View Post
    Wow, just wow.
    Big Fonts! Melodrama!

  6. #6
    Join Date
    Aug 2012
    Posts
    458

    Default

    Quote Originally Posted by DanL View Post
    Big Fonts! Melodrama!
    What are we yelling about! Loud Noises!

  7. #7
    Join Date
    Feb 2013
    Posts
    324

    Default

    opensource drivers are trash, more at 11.

  8. #8
    Join Date
    Jun 2009
    Posts
    1,136

    Default

    Quote Originally Posted by dh04000 View Post
    "David Airlie has been the only Mesa contributor to respond to the Mesa Valgrind posting yet and he suggests some of the errors may be due to kernel ioctls not known by Valgrind. "We access a lot of kernel data via ioctls that valgrind doesn't understand. I'm not saying that is definitely the case but it was in a lot of places."

    Wow, just wow.

    Instead of saying thank you for finding these problems and calling all available programmers to help the debug, the only poster basically says "there isn't any bugs, your program isn't working right, we're prefect and incapable of generating bugs for we're gods. 100% your fault".

    And these people make the drivers? That should scare you a bit. Humility is a good feature in a person, not a bad one
    well valgrind as far as i know can't track down ioctls properly[not without special infrastructure kernel side](same applies to oprofile and traces last time i tried) and he is pointing that out since drivers normally uses a loooot of ioctls, he is not discouraging anyone either but pointing out that every ioctl will probably generate a false positive in valgrind.

    so for now this valgrind outputs should be separated in ioctl/non-ioctl and start tracking them down with more advanced tooling if needed.

    aka a perfectly rational response from a developer

  9. #9
    Join Date
    Feb 2013
    Posts
    438

    Default

    Quote Originally Posted by jrch2k8 View Post
    well valgrind as far as i know can't track down ioctls properly[not without special infrastructure kernel side](same applies to oprofile and traces last time i tried) and he is pointing that out since drivers normally uses a loooot of ioctls, he is not discouraging anyone either but pointing out that every ioctl will probably generate a false positive in valgrind.

    so for now this valgrind outputs should be separated in ioctl/non-ioctl and start tracking them down with more advanced tooling if needed.

    aka a perfectly rational response from a developer
    Valgrind picks up a lot of false positives for software that does anything complicated with memory. I'd expect Mesa to fall into that category. Python supplies a Valgrind suppression file because it throws so many invalid problems in the Python interpreter see http://svn.python.org/projects/pytho...EADME.valgrind for the details.

  10. #10
    Join Date
    Jul 2009
    Posts
    221

    Default

    This article is seriously confusing.

    Valgrind can (and frequently does) report one issue many times, which is probably the main reason the number is so big. I understand no more from it than "valgrind has found some issues".

    Secondly, as pointed out, valgrind does report false positives.

    Yes, they should probably be checked, but why the hell make a big deal of it like something major is up? Especially when you don't understand what it's about?

    I know there's a bit of trolling on these forums but sometimes it seems Michael acts like a troll too...

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •