Announcement

Collapse
No announcement yet.

[BUG] Phoronix fails to install dependencies on Ubuntu 11.04

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

  • [BUG] Phoronix fails to install dependencies on Ubuntu 11.04

    The file install-ubuntu-packages.sh doesn't work properly, because it executes this command:
    Code:
    $ROOT -- "apt-get -y --ignore-missing install $*"
    which yields the following error: sudo: apt-get -y --ignore-missing install yasm: command not found

    The proper line should be: (notice double quotes have been removed)
    Code:
    $ROOT -- apt-get -y --ignore-missing install $*
    so sudo will split it into apt-get as command and the rest as parameters.

  • #2
    Did the developers read this? If no, where do I report bugs?

    Comment


    • #3
      I read it and been meaning to fix it up, again on my TODO list. If you just want to send a patch you can post it and I'll apply it.
      Michael Larabel
      https://www.michaellarabel.com/

      Comment


      • #4
        Originally posted by Michael View Post
        I read it and been meaning to fix it up, again on my TODO list. If you just want to send a patch you can post it and I'll apply it.
        Michael, this is pretty generic and really should affect just about all Ubuntu versions... here's a patch, not sure if it's formatted correctly or not, it's been a while since I last created patches with diff...

        I've tested this on Natty and it resolves the issue there, no guarantees elsewhere, but it should fix it across Ubuntu releases.

        *** install-ubuntu-packages.sh.orig 2011-09-20 20:08:45.141761442 -0400
        --- install-ubuntu-packages.sh 2011-09-20 20:12:10.321750846 -0400
        ***************
        *** 15,21 ****
        if [ -x /usr/bin/aptitude ]; then
        # aptitude is nice since it doesn't fail if a non-existant package is hit
        # See: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503215
        ! $ROOT -- "aptitude -y install $*"
        else
        ! $ROOT -- "apt-get -y --ignore-missing install $*"
        fi
        --- 15,21 ----
        if [ -x /usr/bin/aptitude ]; then
        # aptitude is nice since it doesn't fail if a non-existant package is hit
        # See: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503215
        ! $ROOT -- aptitude -y install $*
        else
        ! $ROOT -- apt-get -y --ignore-missing install $*
        fi

        Comment


        • #5
          Originally posted by DreadPirateJeff View Post
          Michael, this is pretty generic and really should affect just about all Ubuntu versions... here's a patch, not sure if it's formatted correctly or not, it's been a while since I last created patches with diff...

          I've tested this on Natty and it resolves the issue there, no guarantees elsewhere, but it should fix it across Ubuntu releases.

          *** install-ubuntu-packages.sh.orig 2011-09-20 20:08:45.141761442 -0400
          --- install-ubuntu-packages.sh 2011-09-20 20:12:10.321750846 -0400
          ***************
          *** 15,21 ****
          if [ -x /usr/bin/aptitude ]; then
          # aptitude is nice since it doesn't fail if a non-existant package is hit
          # See: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503215
          ! $ROOT -- "aptitude -y install $*"
          else
          ! $ROOT -- "apt-get -y --ignore-missing install $*"
          fi
          --- 15,21 ----
          if [ -x /usr/bin/aptitude ]; then
          # aptitude is nice since it doesn't fail if a non-existant package is hit
          # See: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503215
          ! $ROOT -- aptitude -y install $*
          else
          ! $ROOT -- apt-get -y --ignore-missing install $*
          fi
          Simply that won't fix it if I recall correctly because in quotes for sudo or gksudo (I forget which) it will fail like that when I tried it before I think.
          Michael Larabel
          https://www.michaellarabel.com/

          Comment


          • #6
            bladernr@klaatu:~$ gksudo -- "aptitude -y install checkbox"
            No packages will be installed, upgraded, or removed.
            0 packages upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
            Need to get 0 B of archives. After unpacking 0 B will be used.

            bladernr@klaatu:~$ gksudo -- aptitude -y install checkbox
            No packages will be installed, upgraded, or removed.
            0 packages upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
            Need to get 0 B of archives. After unpacking 0 B will be used.

            bladernr@klaatu:~$ sudo -- "aptitude -y install checkbox"
            sudo: aptitude -y install checkbox: command not found
            bladernr@klaatu:~$ sudo -- aptitude -y install checkbox
            No packages will be installed, upgraded, or removed.
            0 packages upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
            Need to get 0 B of archives. After unpacking 0 B will be used.bladernr@klaatu:~$ gksudo -- "aptitude -y install checkbox"
            No packages will be installed, upgraded, or removed.
            0 packages upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
            Need to get 0 B of archives. After unpacking 0 B will be used.

            bladernr@klaatu:~$ gksudo -- aptitude -y install checkbox
            No packages will be installed, upgraded, or removed.
            0 packages upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
            Need to get 0 B of archives. After unpacking 0 B will be used.

            bladernr@klaatu:~$ sudo -- "aptitude -y install checkbox"
            sudo: aptitude -y install checkbox: command not found
            bladernr@klaatu:~$ sudo -- aptitude -y install checkbox
            No packages will be installed, upgraded, or removed.
            0 packages upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
            Need to get 0 B of archives. After unpacking 0 B will be used.

            For gksudo and sudo at least, on Natty, removing the quotes doesn't fail, while leaving them in does fail for sudo, while gksudo is fine, apparently.

            That being said, I don't have a system to test this using kdesudo.

            So perhaps this will work?

            It's ugly, however I can't think of a prettier way to do this at the moment. So far I've tried the gksudo and sudo bits on Natty and Oneiric and they work fine without quotes, so this preserves the old behaviour for kdesudo which I can't test, and changes it for gksudo and sudo which I have tested.

            *** install-ubuntu-packages.sh.orig 2011-09-20 20:08:45.141761442 -0400
            --- install-ubuntu-packages.sh 2011-09-21 11:15:37.681392855 -0400
            ***************
            *** 15,21 ****
            if [ -x /usr/bin/aptitude ]; then
            # aptitude is nice since it doesn't fail if a non-existant package is hit
            # See: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503215
            ! $ROOT -- "aptitude -y install $*"
            else
            ! $ROOT -- "apt-get -y --ignore-missing install $*"
            ! fi
            --- 15,29 ----
            if [ -x /usr/bin/aptitude ]; then
            # aptitude is nice since it doesn't fail if a non-existant package is hit
            # See: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503215
            ! if [ "$ROOT" == "/usr/bin/kdesudo" ]; then
            ! $ROOT -- "aptitude -y install $*"
            ! else
            ! $ROOT -- aptitude -y install $*
            ! fi
            else
            ! if [ "$ROOT" == "/usr/bin/kdesudo" ]; then
            ! $ROOT -- "apt-get -y --ignore-missing install $*"
            ! else
            ! $ROOT -- apt-get -y --ignore-missing install $*
            ! fi
            ! fi

            Comment


            • #7
              ugh... Ignore my last post... ubuntu uses dash to provide sh functionality, not bash... I write everything in bash, so the comparison operator is wrong... this corrects it for sh/dash since I am only messing with the ubuntu script.


              *** install-ubuntu-packages.sh.orig 2011-09-21 13:48:00.197625956 -0400
              --- install-ubuntu-packages.sh 2011-09-21 14:34:11.045564550 -0400
              ***************
              *** 15,21 ****
              if [ -x /usr/bin/aptitude ]; then
              # aptitude is nice since it doesn't fail if a non-existant package is hit
              # See: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503215
              ! $ROOT -- "aptitude -y install $*"
              else
              ! $ROOT -- "apt-get -y --ignore-missing install $*"
              fi
              --- 15,29 ----
              if [ -x /usr/bin/aptitude ]; then
              # aptitude is nice since it doesn't fail if a non-existant package is hit
              # See: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503215
              ! if [ "$ROOT" = '/usr/bin/kdesudo' ]; then
              ! $ROOT -- "aptitude -y install $*"
              ! else
              ! $ROOT -- aptitude -y install $*
              ! fi
              else
              ! if [ "$ROOT" = '/usr/bin/kdesudo' ]; then
              ! $ROOT -- "apt-get -y --ignore-missing install $*"
              ! else
              ! $ROOT -- apt-get -y --ignore-missing install $*
              ! fi
              fi

              Comment

              Working...
              X