Announcement

Collapse
No announcement yet.

X.Org Server: 1,047 Warnings Reduced To Zero

Collapse
X
  • Filter
  • Time
  • Show
Clear All
new posts

  • X.Org Server: 1,047 Warnings Reduced To Zero

    Phoronix: X.Org Server: 1,047 Warnings Reduced To Zero

    Keith Packard has been working on an X.Org Server clean-up of the aging code-base and he's managed to reduce the number of generated warnings down to zero...

    http://www.phoronix.com/vr.php?view=MTU0MzI

  • #2
    But did it solve bugs ? lol

    Comment


    • #3
      Guess there is no need for wayland now. :P

      Comment


      • #4
        great. Hopefully this gets merged back into RHEL 7

        Comment


        • #5
          how to waste your life.

          Comment


          • #6
            Nice work. I might run cppcheck on it tonight, alongside with providing patches to anything I find myself able to fix.

            Comment


            • #7
              Originally posted by fabioamd87 View Post
              how to waste your life.
              How is reducing the barrier to entry by producng good and compliant code a waste of time? It'd prevent future bugs too I bet, simply because it makes more sense.

              Comment


              • #8
                Originally posted by stiiixy View Post
                How is reducing the barrier to entry by producng good and compliant code a waste of time? It'd prevent future bugs too I bet, simply because it makes more sense.
                Also, fixing warnings usually fixes bugs you don't even know about. The kind of bug your find in some esoteric contexts.

                Comment


                • #9
                  why, xorg server has future?

                  Comment


                  • #10
                    Is he a magician?

                    1047 warnings!

                    Excelent work Keith!

                    Comment


                    • #11
                      Originally posted by mrugiero View Post
                      Also, fixing warnings usually fixes bugs you don't even know about. The kind of bug your find in some esoteric contexts.
                      Exactly...warnings can indicate possible bugs that could be hard to track down due to how the compiler handles code that's not written to standards. Now hopefully some bugs that do creep in can be found and squashed quickly in the cleaned up codebase.

                      A clean codebase can help with future bugfixing and updating too.

                      Comment


                      • #12
                        warnings are just....warnings. They may or may not indicate bugs. 99.999% of them are just the compiler being very picky.

                        it is probably a good thing to clear them as with 1000+ warnings it is impossible to assess if they are all safe warnings.

                        My guess is that since Keith do not mention any discovered bugs by the exercise probably means that he has not found any or else he would have been proud to mention it.

                        Comment


                        • #13
                          Originally posted by lano1106 View Post
                          warnings are just....warnings.
                          Exactly. But a warning is in fact code that might be unpredictable. Unpredictable means you can't be sure it does what you intend it to do.

                          They may or may not indicate bugs. 99.999% of them are just the compiler being very picky.
                          Nope. 99.999% of them are the compiler telling you you are ignoring the standard, making assumptions about how the language works that are not set in the standard, etc. This means you don't know what this code does.

                          it is probably a good thing to clear them as with 1000+ warnings it is impossible to assess if they are all safe warnings.
                          Well, the only way to tell is to actually trying to make sense of them. And if you do so, fixing them is in most cases trivial.

                          My guess is that since Keith do not mention any discovered bugs by the exercise probably means that he has not found any or else he would have been proud to mention it.
                          Again, usually warnings are either fixed because a bug related was tracked down to it, or causing problems in very specific contexts (it could be hardware specific, compiler specific, etc). The latter means he can't test by himself if he fixed any real life bug.

                          Originally posted by fabioamd87 View Post
                          why, xorg server has future?
                          Yes, it does. Wayland does not intend to replace X.org in all use cases, but rather on desktop and mobile.
                          Also, some applications might never get ported, and the X.org server is still needed to support XWayland.

                          Comment


                          • #14
                            Yep thanks Keith

                            Comment


                            • #15
                              Originally posted by lano1106 View Post
                              warnings are just....warnings. They may or may not indicate bugs. 99.999% of them are just the compiler being very picky.

                              it is probably a good thing to clear them as with 1000+ warnings it is impossible to assess if they are all safe warnings.

                              My guess is that since Keith do not mention any discovered bugs by the exercise probably means that he has not found any or else he would have been proud to mention it.
                              Old warnings are generally safe, but new ones can indicate problems. The main thing clearing all of them out does is make it obvious when new warnings are being introduced, and make it easy to figure out why when that happens. When there are tons of old ones doing nothing, there can be valid warnings that start happening and no one will notice them mixed in with all the old ones.

                              Comment

                              Working...
                              X